Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8029

Conda-lsst Linux lsst-afw build failure on CentOS5.

    Details

    • Type: Bug
    • Status: Done
    • Priority: Blocker
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Templates:
    • Story Points:
      2
    • Epic Link:
    • Team:
      SQuaRE

      Description

      These tests break on afw:

      https://github.com/lsst/afw/blob/5255666d358266bc09c916f7757b040bf3b2e76c/tests/testSpatialCell.py#L327-L329

      The complete log (VERY long):
      https://gist.github.com/jmatt/76493e85ba0ade0c81afd93e1a8884a3

      The specific test failure:

      ======================================================================
      ERROR: testInsertCandidate (__main__.TestMaskedImageCandidateCase)
      Test that we can use SpatialCellMaskedImageCandidate
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "tests/testSpatialCell.py", line 327, in testInsertCandidate
          self.assertEqual(im.get(0, 0), flux)  # This is how TestMaskedImageCandidate sets its pixels
        File "/opt/conda-lsst/miniconda/conda-bld/work/python/lsst/afw/image/imageLib.py", line 4331, in get
          return _imageLib.ImageF_get(self, x, y)
      LengthError: 
        File "src/image/Image.cc", line 277, in lsst::afw::image::ImageBase<PixelT>::PixelReference lsst::afw::image::ImageBase<PixelT>::operator()(int, int, const lsst::afw::image::CheckIndices&) [with PixelT = float; lsst::afw::image::ImageBase<PixelT>::PixelReference = float&]
          Index (0, 0) is out of range [0---1], [0---1] {0}
      lsst::pex::exceptions::LengthError: 'Index (0, 0) is out of range [0---1], [0---1]'
       
       
      ----------------------------------------------------------------------
      Ran 15 tests in 0.244s
       
      FAILED (errors=1)
      The following tests failed:
      /opt/conda-lsst/miniconda/conda-bld/work/tests/.tests/testSpatialCell.py.failed
      1 tests failed
      

      There is no plan to directly address this on CentOS5. Instead we'll move to CentOS6 - specifically the Conda-forge's docker image.

        Issue Links

          Activity

          Hide
          jmatt J Matt Peterson added a comment -

          Jim Bosch's afw changes have fixed the Conda binary build of afw for v12.1+1.

          Show
          jmatt J Matt Peterson added a comment - Jim Bosch 's afw changes have fixed the Conda binary build of afw for v12.1+1.
          Hide
          jmatt J Matt Peterson added a comment -

          Jim Bosch's meas_algorithm and ip_diffim changes have successfully built in the Conda linux binary build for v12.1+1. I will report in again when I've tested the binaries against the demo. I'm not actually sure if the demo has any code coverage but that's generally how I confirm the success of a conda build.

          Thanks again Jim Bosch!

          Show
          jmatt J Matt Peterson added a comment - Jim Bosch 's meas_algorithm and ip_diffim changes have successfully built in the Conda linux binary build for v12.1+1. I will report in again when I've tested the binaries against the demo. I'm not actually sure if the demo has any code coverage but that's generally how I confirm the success of a conda build. Thanks again Jim Bosch !
          Hide
          jmatt J Matt Peterson added a comment -

          Looks good to me. The v12.1 Conda Linux binaries are created and tested with the demo.

          Show
          jmatt J Matt Peterson added a comment - Looks good to me. The v12.1 Conda Linux binaries are created and tested with the demo.
          Hide
          jbosch Jim Bosch added a comment -

          It occurs to me that this is an API change, though a minor one, I better do a quick RFC before merging.

          Show
          jbosch Jim Bosch added a comment - It occurs to me that this is an API change, though a minor one, I better do a quick RFC before merging.
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master.

          Show
          jbosch Jim Bosch added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jmatt J Matt Peterson
              Reviewers:
              J Matt Peterson
              Watchers:
              Frossie Economou, Jim Bosch, J Matt Peterson, John Swinbank, Joshua Hoblitt, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development