Ian Sullivan, would you mind reviewing this simple patch, please?
price@price-laptop:~/LSST/pipe/drivers (tickets/DM-8033=) $ git sub-patch
|
commit 16008d11330b1d20724f8bca5457c34835763cd3
|
Author: Paul Price <price@astro.princeton.edu>
|
Date: Tue Oct 18 22:15:47 2016 -0400
|
|
FringeTask: fix confusion between mask plane and mask bit
|
|
setMaskFromFootprintList wants a mask bit, but we have been giving
|
it a mask plane.
|
|
Thanks to Michitaro Koike for discovering and fixing this bug.
|
|
diff --git a/python/lsst/pipe/drivers/constructCalibs.py b/python/lsst/pipe/drivers/constructCalibs.py
|
index e9e8269..12ed12b 100644
|
--- a/python/lsst/pipe/drivers/constructCalibs.py
|
+++ b/python/lsst/pipe/drivers/constructCalibs.py
|
@@ -854,7 +854,7 @@ class FringeTask(CalibTask):
|
mi /= bgLevel
|
footprintSets = self.detection.detectFootprints(exposure, sigma=self.config.detectSigma)
|
mask = exposure.getMaskedImage().getMask()
|
- detected = mask.addMaskPlane("DETECTED")
|
+ detected = 1 << mask.addMaskPlane("DETECTED")
|
for fpSet in (footprintSets.positive, footprintSets.negative):
|
if fpSet is not None:
|
afwDet.setMaskFromFootprintList(mask, fpSet.getFootprints(), detected)
|
Ian Sullivan, would you mind reviewing this simple patch, please?
price@price-laptop:~/LSST/pipe/drivers (tickets/DM-8033=) $ git sub-patch
commit 16008d11330b1d20724f8bca5457c34835763cd3
Author: Paul Price <price@astro.princeton.edu>
Date: Tue Oct 18 22:15:47 2016 -0400
FringeTask: fix confusion between mask plane and mask bit
setMaskFromFootprintList wants a mask bit, but we have been giving
it a mask plane.
Thanks to Michitaro Koike for discovering and fixing this bug.
diff --git a/python/lsst/pipe/drivers/constructCalibs.py b/python/lsst/pipe/drivers/constructCalibs.py
index e9e8269..12ed12b 100644
--- a/python/lsst/pipe/drivers/constructCalibs.py
+++ b/python/lsst/pipe/drivers/constructCalibs.py
@@ -854,7 +854,7 @@ class FringeTask(CalibTask):
mi /= bgLevel
footprintSets = self.detection.detectFootprints(exposure, sigma=self.config.detectSigma)
mask = exposure.getMaskedImage().getMask()
- detected = mask.addMaskPlane("DETECTED")
+ detected = 1 << mask.addMaskPlane("DETECTED")
for fpSet in (footprintSets.positive, footprintSets.negative):
if fpSet is not None:
afwDet.setMaskFromFootprintList(mask, fpSet.getFootprints(), detected)