Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8049

Crop related classes need to be refactored

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: SUIT
    • Labels:
      None

      Description

      When I am working on the unit test for Crop class, I noticed that it uses switch bitpix to deal with different data type. Since float is used for FitsRead, it should be updated accordingly.

      [Update 11-09-16]
      In July 2015, the CropAndCenter was refactored. When it was refactored, I noticed that Crop.java and CropAndCenter have many common codes. So a method do_crop 

      Fits do_crop(Fits inFits, int min_x, int min_y, int max_x, int max_y)

      was added to the CropAndCenter class. Thus, the Crop.java became redundancy. It could be removed from the system. I searched usages and found it is not used at all. I think that
      it is safe to remove it now.

      This ticket will include the following work:

      • Remove Crop.java
      • Refactor CropFile.java in the same manner as CropAndCenter, FitsRead etc.
      • Add unit tests for both CropAndCenter and CropFile classes

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9176 Create unit test for package edu.caltech.ipac.visualize.plot

          • To Do
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8984 Delete Crop.java and CropTest.java

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2952 Crop needs to be refactored

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            zhang Lijun Zhang [X] (Inactive) added a comment -

            This ticket included adding unit tests and refactoring the codes and deprecating classes. The unit tests were added before the refactoring to ensure that the refactoring did not introduce the problem.

            Show
            zhang Lijun Zhang [X] (Inactive) added a comment - This ticket included adding unit tests and refactoring the codes and deprecating classes. The unit tests were added before the refactoring to ensure that the refactoring did not introduce the problem.
            Hide
            Permalink
            ymei Yi Mei [X] (Inactive) added a comment -

            Tested the branch DM-8049-AllCropClasses: "gradle test" ran successfully.

            Show
            ymei Yi Mei [X] (Inactive) added a comment - Tested the branch DM-8049 -AllCropClasses: "gradle test" ran successfully.
            Hide
            Permalink
            zhang Lijun Zhang [X] (Inactive) added a comment -

            Merged

            Show
            zhang Lijun Zhang [X] (Inactive) added a comment - Merged

              People

              Assignee:
              zhang Lijun Zhang [X] (Inactive)
              Reporter:
              zhang Lijun Zhang [X] (Inactive)
              Reviewers:
              Trey Roby, Yi Mei [X] (Inactive)
              Watchers:
              Lijun Zhang [X] (Inactive), Xiuqin Wu [X] (Inactive), Yi Mei [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.