Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8103

Add method to find edge pixels to SpanSet

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      DRP F16-6, DRP S17-1, DRP S17-2
    • Team:
      Data Release Production

      Description

      Add a method to SpanSets which returns a new SpanSet that contains the pixels at the boarder of the original SpanSet

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            Thanks for looking at this

            Show
            nlust Nate Lust added a comment - Thanks for looking at this
            Hide
            swinbank John Swinbank added a comment -

            I believe this is effectively a port of findEdgePixels() to new-footprints. Is that correct Nate Lust? [For future reference, it's helpful to specify things like that in the ticket description.]

            Show
            swinbank John Swinbank added a comment - I believe this is effectively a port of findEdgePixels() to new-footprints. Is that correct Nate Lust ? [For future reference, it's helpful to specify things like that in the ticket description.]
            Hide
            nlust Nate Lust added a comment -

            Sort of, as it is a different class, and works completely differently. In practice it is supposed to have the same end result, so in that sense yes it is.

            Show
            nlust Nate Lust added a comment - Sort of, as it is a different class, and works completely differently. In practice it is supposed to have the same end result, so in that sense yes it is.
            Hide
            fred3m Fred Moolekamp added a comment - - edited

            Everything looks good. I have no comments, other than appreciating that you also added very useful __repr__ and __str__ methods to SpanSets.

            Show
            fred3m Fred Moolekamp added a comment - - edited Everything looks good. I have no comments, other than appreciating that you also added very useful __repr__ and __str__ methods to SpanSets.
            Hide
            swinbank John Swinbank added a comment - - edited

            Before merging, please fix the typos in the commit message for b3b9fa8 ("bindsing", "debuggin").

            Show
            swinbank John Swinbank added a comment - - edited Before merging, please fix the typos in the commit message for b3b9fa8 ("bindsing", "debuggin").
            Hide
            swinbank John Swinbank added a comment - - edited

            Also, commit messages which say things like "additionally, ..." or "in addition, ..." are a red flag that you should be using more fine-grained commits. Please fix bugs and add new features on separate commits.

            Show
            swinbank John Swinbank added a comment - - edited Also, commit messages which say things like "additionally, ..." or "in addition, ..." are a red flag that you should be using more fine-grained commits. Please fix bugs and add new features on separate commits.
            Hide
            swinbank John Swinbank added a comment -

            Also also, I think some more documentation would be helpful. What does it mean to "find the pixels that are on the border of the SpanSet"? Does that mean they are inside the SpanSet but touching its edge? Or outside the SpanSet but adjacent to it? Or both?

            Show
            swinbank John Swinbank added a comment - Also also, I think some more documentation would be helpful. What does it mean to "find the pixels that are on the border of the SpanSet"? Does that mean they are inside the SpanSet but touching its edge? Or outside the SpanSet but adjacent to it? Or both?
            Hide
            nlust Nate Lust added a comment -

            merged to pybind11 branch

            Show
            nlust Nate Lust added a comment - merged to pybind11 branch

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                nlust Nate Lust
                Reviewers:
                Fred Moolekamp
                Watchers:
                Fred Moolekamp, John Swinbank, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel