Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8108

Update stack code to use new Footprint API

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      14
    • Epic Link:
    • Sprint:
      DRP F16-6, DRP S17-2, DRP S17-3, DRP S17-4, DRP S17-5
    • Team:
      Data Release Production

      Description

      The API change to footprints will require changes to many things. This is a ticket to capture the work related to updating to the new API.

        Attachments

          Issue Links

          has to be done before

          Improvement - An improvement or enhancement to an existing feature or task. DM-4639 modernize afw code and reduce doxygen errors

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8107 Implement new footprints based on API

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8693 Wrap SpanSets class with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9105 Make SpanSet operator templates more generic

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9996 Review SpanSet & Footprint API

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10361 lsst_dm_stack_demo failing with new Footprints

          • Done

            Activity

            Ascending order - Click to sort in descending order
            17 older comments
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Russell Owen we had talked a bit ago about fixing the errors on 7177 sorry if somehow there was a miscommunication on my part

            Show
            nlust Nate Lust added a comment - Russell Owen we had talked a bit ago about fixing the errors on 7177 sorry if somehow there was a miscommunication on my part
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Nate Lust yes, you go first: note the new "has to be done before" link.

            Show
            krzys Krzysztof Findeisen added a comment - Nate Lust yes, you go first: note the new "has to be done before" link.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Thanks, I'm on mobile and things are not as easy to see.

            Show
            nlust Nate Lust added a comment - Thanks, I'm on mobile and things are not as easy to see.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Ok, I've finished my part of the review (I think). Some suggestions on syntax (e.g. PTR and range-based for) which I trust you to cleanup, plus some complaints about excess verbosity in the new API for which there might not be a good solution.

            Show
            Parejkoj John Parejko added a comment - Ok, I've finished my part of the review (I think). Some suggestions on syntax (e.g. PTR and range-based for ) which I trust you to cleanup, plus some complaints about excess verbosity in the new API for which there might not be a good solution.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            All, I tried to address all the comments people had on this, including some comments on the APIs. This ticket however was not a ticket to review the APIs, but to check how the code base was updated to the new Footprints APIs which were previously reviewed. Where possible I tried to make accommodations. I think some of the friction will also go away as people start to used SpanSets in places where appropriate opposed to SpanSets inside Footprints. We can of course seek to change the API further if we find friction points after a honeymoon period getting used to things. Thank you for all your hard work on the review.

            Show
            nlust Nate Lust added a comment - All, I tried to address all the comments people had on this, including some comments on the APIs. This ticket however was not a ticket to review the APIs, but to check how the code base was updated to the new Footprints APIs which were previously reviewed. Where possible I tried to make accommodations. I think some of the friction will also go away as people start to used SpanSets in places where appropriate opposed to SpanSets inside Footprints. We can of course seek to change the API further if we find friction points after a honeymoon period getting used to things. Thank you for all your hard work on the review.

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, John Parejko, John Swinbank, Krzysztof Findeisen, Nate Lust, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.