Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8108

Update stack code to use new Footprint API

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • None
    • 14
    • DRP F16-6, DRP S17-2, DRP S17-3, DRP S17-4, DRP S17-5
    • Data Release Production

    Description

      The API change to footprints will require changes to many things. This is a ticket to capture the work related to updating to the new API.

      Attachments

        Issue Links

          Activity

            nlust Nate Lust added a comment -

            rowen we had talked a bit ago about fixing the errors on 7177 sorry if somehow there was a miscommunication on my part

            nlust Nate Lust added a comment - rowen we had talked a bit ago about fixing the errors on 7177 sorry if somehow there was a miscommunication on my part

            nlust yes, you go first: note the new "has to be done before" link.

            krzys Krzysztof Findeisen added a comment - nlust yes, you go first: note the new "has to be done before" link.
            nlust Nate Lust added a comment -

            Thanks, I'm on mobile and things are not as easy to see.

            nlust Nate Lust added a comment - Thanks, I'm on mobile and things are not as easy to see.
            Parejkoj John Parejko added a comment -

            Ok, I've finished my part of the review (I think). Some suggestions on syntax (e.g. PTR and range-based for) which I trust you to cleanup, plus some complaints about excess verbosity in the new API for which there might not be a good solution.

            Parejkoj John Parejko added a comment - Ok, I've finished my part of the review (I think). Some suggestions on syntax (e.g. PTR and range-based for ) which I trust you to cleanup, plus some complaints about excess verbosity in the new API for which there might not be a good solution.
            nlust Nate Lust added a comment -

            All, I tried to address all the comments people had on this, including some comments on the APIs. This ticket however was not a ticket to review the APIs, but to check how the code base was updated to the new Footprints APIs which were previously reviewed. Where possible I tried to make accommodations. I think some of the friction will also go away as people start to used SpanSets in places where appropriate opposed to SpanSets inside Footprints. We can of course seek to change the API further if we find friction points after a honeymoon period getting used to things. Thank you for all your hard work on the review.

            nlust Nate Lust added a comment - All, I tried to address all the comments people had on this, including some comments on the APIs. This ticket however was not a ticket to review the APIs, but to check how the code base was updated to the new Footprints APIs which were previously reviewed. Where possible I tried to make accommodations. I think some of the friction will also go away as people start to used SpanSets in places where appropriate opposed to SpanSets inside Footprints. We can of course seek to change the API further if we find friction points after a honeymoon period getting used to things. Thank you for all your hard work on the review.

            People

              nlust Nate Lust
              nlust Nate Lust
              Fred Moolekamp
              Fred Moolekamp, John Parejko, John Swinbank, Krzysztof Findeisen, Nate Lust, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.