Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8113

Implement fixes required

    Details

    • Story Points:
      10
    • Sprint:
      Alert Production S17 - 2, Alert Production S17 - 3
    • Team:
      Alert Production

      Description

      After failures are assessed in DM-8112, implement the fixes to the OPMb algorithm that are required to correct the failure modes.

      Deliverable: Implement set of fixes to current algorithm or proposed change to new algorithm to make current failures run properly.

        Attachments

          Issue Links

            Activity

            Hide
            cmorrison Chris Morrison added a comment - - edited

            The code can be found here:

            https://github.com/lsst/meas_astrom/tree/u/morriscb/pythonOPMb/python/lsst/meas/astrom

            The changes are to:
            astrometry.py
            matchOptimisticB.py
            optimistic_pattern_matcher_b_3D.py

            Show
            cmorrison Chris Morrison added a comment - - edited The code can be found here: https://github.com/lsst/meas_astrom/tree/u/morriscb/pythonOPMb/python/lsst/meas/astrom The changes are to: astrometry.py matchOptimisticB.py optimistic_pattern_matcher_b_3D.py
            Hide
            krughoff Simon Krughoff added a comment -

            O.K. I made a pull request and left some minor comments. You can decide what you do now and what you take care of in the "stackification" step, but so things don't fall through the cracks, it makes sense to do anything that's not going to delay things too much now.

            I couldn't mark the review "approved" since I started it, but I do approve it.

            Show
            krughoff Simon Krughoff added a comment - O.K. I made a pull request and left some minor comments. You can decide what you do now and what you take care of in the "stackification" step, but so things don't fall through the cracks, it makes sense to do anything that's not going to delay things too much now. I couldn't mark the review "approved" since I started it, but I do approve it.
            Hide
            krughoff Simon Krughoff added a comment -

            I think we are all on the same page, but just to be clear, this is not approval to merge to master, just to close this work and move on to the next phase.

            Show
            krughoff Simon Krughoff added a comment - I think we are all on the same page, but just to be clear, this is not approval to merge to master, just to close this work and move on to the next phase.
            Hide
            cmorrison Chris Morrison added a comment -

            Before I close this ticket, what should I do with the pull request?

            Show
            cmorrison Chris Morrison added a comment - Before I close this ticket, what should I do with the pull request?
            Hide
            cmorrison Chris Morrison added a comment -

            Closed pull request (https://github.com/lsst/meas_astrom/pull/60). Will incorporate these comments as part of DM-9750.

            Show
            cmorrison Chris Morrison added a comment - Closed pull request ( https://github.com/lsst/meas_astrom/pull/60 ). Will incorporate these comments as part of DM-9750 .

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                cmorrison Chris Morrison
                Reviewers:
                Simon Krughoff
                Watchers:
                Chris Morrison, Colin Slater, Paul Price, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: