Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8114

Create DMTNs for this epic

    XMLWordPrintable

Details

    • 10
    • AP S18-6
    • Alert Production

    Description

      Create DMTN documents chronicling the work done for this epic and knowledge gained about the Optimistic Pattern Matcher algorithm.

      Deliverables: 1-3 DMTNs:
      Document on the prototype python OPMb matcher.
      Document describing the data and reasons the algorithm failures.
      Document fully describing the final algorithm implemented in the stack.

      Attachments

        Activity

          Cloned DMTN repository.

          cmorrison Chris Morrison [X] (Inactive) added a comment - Cloned DMTN repository.

          Just to make sure I'm reviewing the right thing — the text is what currently appears at https://dmtn-031.lsst.io, right? (It's marked as “Latest Revision: 2018-02-21”, but I think that's just because the machinery needs some adjustment.)

          swinbank John Swinbank added a comment - Just to make sure I'm reviewing the right thing — the text is what currently appears at https://dmtn-031.lsst.io , right? (It's marked as “Latest Revision: 2018-02-21”, but I think that's just because the machinery needs some adjustment.)

          I would say just look at the rst on github. I didn't even know the io page was updating at all let alone when it will update after pushing the latest version.

          cmorrison Chris Morrison [X] (Inactive) added a comment - I would say just look at the rst on github. I didn't even know the io page was updating at all let alone when it will update after pushing the latest version.
          tjenness Tim Jenness added a comment -

          https://dmtn-031.lsst.io/v/index.html indicates it was updated today.

          The copyright needs updating (it says 2016).

          tjenness Tim Jenness added a comment - https://dmtn-031.lsst.io/v/index.html indicates it was updated today. The copyright needs updating (it says 2016).

          Since there wasn't a outstanding PR, I've made a bunch of tweaks to the text and added a series of comments (as “notes”). These are now available on this PR against master.

          Please do read the PR and take my formatting/typo/copy-editing fixes as suggestions rather than requirements! The things in “note” blocks are what I'd really like you to address.

          Overall, this is very nice, though. I've made a few suggestions for clarification of the wording, but the material seems comprehensive and well thought through. I like it!

          swinbank John Swinbank added a comment - Since there wasn't a outstanding PR, I've made a bunch of tweaks to the text and added a series of comments (as “notes”). These are now available on this PR against master . Please do read the PR and take my formatting/typo/copy-editing fixes as suggestions rather than requirements! The things in “note” blocks are what I'd really like you to address. Overall, this is very nice, though. I've made a few suggestions for clarification of the wording, but the material seems comprehensive and well thought through. I like it!

          Thanks for your responses to my comments!

          I am now happy with almost everything. There are two comments outstanding which I'm still not clear about — could you take a look? (I think maybe you already explained one to me in person, but I can't reconstruct it from the text, which I think means the text still needs a bit of tweaking).

          Apart from those two, you should probably cast an eye over my edits at https://github.com/lsst-dm/dmtn-031/pull/1/commits/ea1c5e759a12263612139c7001f922c9958a503b just to make sure that none of my editing altered your meaning or introduced any errors.

          Then I think we're good to go...

          swinbank John Swinbank added a comment - Thanks for your responses to my comments! I am now happy with almost everything. There are two comments outstanding which I'm still not clear about — could you take a look? (I think maybe you already explained one to me in person, but I can't reconstruct it from the text, which I think means the text still needs a bit of tweaking). Apart from those two, you should probably cast an eye over my edits at https://github.com/lsst-dm/dmtn-031/pull/1/commits/ea1c5e759a12263612139c7001f922c9958a503b just to make sure that none of my editing altered your meaning or introduced any errors. Then I think we're good to go...

          Merged u/swinbank/edit edit's into main text.

          cmorrison Chris Morrison [X] (Inactive) added a comment - Merged u/swinbank/edit edit's into main text.

          People

            cmorrison Chris Morrison [X] (Inactive)
            cmorrison Chris Morrison [X] (Inactive)
            John Swinbank
            Chris Morrison [X] (Inactive), John Swinbank, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.