Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8128

Make modification to individual Mapper.paf files for RFC-232-237

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP F16-6
    • Team:
      Data Release Production

      Description

      This will collect the recommendations for all of the individual mapper dataset changes into a single ticket. These are changes to the Mapper.paf files to correct bugs or inconsistencies. However, there is no plan to move template locations.

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            The ticket DM-8128 comes off of RFC-232, 233, 234, 235, 236, and 237. I left these tickets open for a month to allow feedback from any of the camera teams. Time to close. Each of you has been assigned one or two Mappers as well as the changes in obs_base. Please note that obs_base/policy/exposures.yaml and datasets.yaml contains datasets which have be moved to obs_base. The Mapper.paf files in the camera directories contain camera specific overrides to some of those datasets (for example, only the template for a dataset may live in the paf file and the rest may live in obs_base/policy/datasets.yaml or exposures.yaml)

            Please review the changes assigned to you and comment through a pull request, but do not mark the ticket as reviewed.

            Paul: HSCMapper and SuprimecamMapper
            Colin: DecamMapper
            John: testMapper
            Yusra: SdssMapper
            Simon: LsstSimMapper and MegacamMapper (Simon, you probably know more than anyone about these two, or can hand them off to someone who does know).

            I have also assigned you all to DM-8138, with is a set of common changes based on RFC-247. Since 8138 is on top of 8137, you should be able to review the two tickets simultaneously.

            Show
            pgee Perry Gee added a comment - The ticket DM-8128 comes off of RFC-232 , 233, 234, 235, 236, and 237. I left these tickets open for a month to allow feedback from any of the camera teams. Time to close. Each of you has been assigned one or two Mappers as well as the changes in obs_base. Please note that obs_base/policy/exposures.yaml and datasets.yaml contains datasets which have be moved to obs_base. The Mapper.paf files in the camera directories contain camera specific overrides to some of those datasets (for example, only the template for a dataset may live in the paf file and the rest may live in obs_base/policy/datasets.yaml or exposures.yaml) Please review the changes assigned to you and comment through a pull request, but do not mark the ticket as reviewed. Paul: HSCMapper and SuprimecamMapper Colin: DecamMapper John: testMapper Yusra: SdssMapper Simon: LsstSimMapper and MegacamMapper (Simon, you probably know more than anyone about these two, or can hand them off to someone who does know). I have also assigned you all to DM-8138 , with is a set of common changes based on RFC-247 . Since 8138 is on top of 8137, you should be able to review the two tickets simultaneously.
            Hide
            price Paul Price added a comment -

            For obs_subaru, tickets/DM-8138 was branched from tickets/DM-8128, so the review is posted on DM-8138.

            Show
            price Paul Price added a comment - For obs_subaru, tickets/ DM-8138 was branched from tickets/ DM-8128 , so the review is posted on DM-8138 .
            Hide
            pgee Perry Gee added a comment -

            There is cleanup in the python code of sdssMapper.py and lsstSimMapper.py which needs to be done because of removed datasets (such as goodSeeingCoadd_Id)

            Show
            pgee Perry Gee added a comment - There is cleanup in the python code of sdssMapper.py and lsstSimMapper.py which needs to be done because of removed datasets (such as goodSeeingCoadd_Id)
            Hide
            ctslater Colin Slater added a comment -

            obs_decam comments are posted on DM-8138 as well.

            Show
            ctslater Colin Slater added a comment - obs_decam comments are posted on DM-8138 as well.
            Hide
            krughoff Simon Krughoff added a comment -

            Comments on DM-8138 of obs_lsstSim

            Show
            krughoff Simon Krughoff added a comment - Comments on DM-8138 of obs_lsstSim
            Hide
            pgee Perry Gee added a comment -

            Paf file changes were made with DM-8138. I will still provide a checkin of each of the obs_* packages which exactly lists the deletions for DM-8128 in the checkin log, as requested in the review of this ticket.

            Show
            pgee Perry Gee added a comment - Paf file changes were made with DM-8138 . I will still provide a checkin of each of the obs_* packages which exactly lists the deletions for DM-8128 in the checkin log, as requested in the review of this ticket.
            Hide
            pgee Perry Gee added a comment -

            A full list of deletions as requested which involved DM-8128 will be made on the DM-8128 ticket.

            Show
            pgee Perry Gee added a comment - A full list of deletions as requested which involved DM-8128 will be made on the DM-8128 ticket.
            Hide
            pgee Perry Gee added a comment -

            John Swinbank I left this open because I still have a few comments to make in the individual Mapper.paf files which were changed on this branch, then I will close this ticket. Most of the functional changes were actually merged with DM-8138, as they were reviewed together.

            Show
            pgee Perry Gee added a comment - John Swinbank I left this open because I still have a few comments to make in the individual Mapper.paf files which were changed on this branch, then I will close this ticket. Most of the functional changes were actually merged with DM-8138 , as they were reviewed together.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                pgee Perry Gee
                Reviewers:
                Colin Slater, John Parejko, Paul Price, Simon Krughoff, Yusra AlSayyad
                Watchers:
                Colin Slater, Jim Bosch, John Parejko, Michael Wood-Vasey, Paul Price, Perry Gee, Simon Krughoff, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel