Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8146

Remove deprecated FFTW API usage from meas_base

    Details

      Description

      As discussed in DM-5123, meas_base uses fftw_plan_r2r_2d, which is not compatible with MKL FFTW and this causes problems in conda environments that use MKL.

      The suggestion from DM-5123 is to rewrite the code to use fftw_plan_c2r_2d and the DRP team was nominated for this work.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            It seems this API is messing up the Intel compiler as well.

            Show
            tjenness Tim Jenness added a comment - It seems this API is messing up the Intel compiler as well.
            Hide
            yusra Yusra AlSayyad added a comment -

            Discussion concludes we still want to do this but it's not trivial

            Show
            yusra Yusra AlSayyad added a comment - Discussion concludes we still want to do this but it's not trivial
            Hide
            cwalter Chris Walter added a comment -

            I believe (but don't actually know) that this may have major performance implications, at least for those of us working at NERSC, on our work.  Look at page 32 of

            https://github.com/wscullin/ecp_python_tutorial/tree/master/slides

            This shows a factor of five for numpy based operations without MKL on KNL processors. Certainly the sims stack and imSim/GalSim make heavy use of these python libraries for processing.

             

            Show
            cwalter Chris Walter added a comment - I believe (but don't actually know) that this may have major performance implications, at least for those of us working at NERSC, on our work.  Look at page 32 of https://github.com/wscullin/ecp_python_tutorial/tree/master/slides This shows a factor of five for numpy based operations without MKL on KNL processors. Certainly the sims stack and imSim/GalSim make heavy use of these python libraries for processing.  
            Hide
            cwalter Chris Walter added a comment -

            In 

            https://community.lsst.org/t/why-do-we-use-the-nomkl-version-of-the-python-modules/2271/12

            Heather refers to "I was able to get Mario’s suggested changes incorporated into meas_base and built at NERSC." Are these changes suggested by Mario documented somewhere?

             

            Show
            cwalter Chris Walter added a comment - In  https://community.lsst.org/t/why-do-we-use-the-nomkl-version-of-the-python-modules/2271/12 Heather refers to "I was able to get Mario’s suggested changes incorporated into meas_base and built at NERSC." Are these changes suggested by Mario documented somewhere?  
            Show
            tjenness Tim Jenness added a comment - Chris Walter : https://jira.lsstcorp.org/browse/DM-5123?focusedCommentId=49484&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-49484

              People

              • Assignee:
                Unassigned
                Reporter:
                tjenness Tim Jenness
                Watchers:
                Chris Walter, Jim Bosch, John Swinbank, Robert Lupton, Tim Jenness, Yusra AlSayyad
              • Votes:
                3 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel