Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8173

Implement interact method for display_firefly

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Sprint:
      SUIT Sprint 2017-4
    • Team:
      Science User Interface

      Description

      The interact method of an afwDisplay.Display enters an interactive loop, listening for key presses in display and firing callbacks set by setCallback. Make these methods work for the display_firefly backend.

        Attachments

          Issue Links

            Activity

            No builds found.
            shupe David Shupe created issue -
            shupe David Shupe made changes -
            Field Original Value New Value
            Epic Link DM-7284 [ 26369 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-11 [ 251 ] SUIT Sprint 2016-12 [ 294 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-12 [ 294 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-01 [ 299 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-01 [ 299 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-2 [ 309 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-2 [ 309 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-3 [ 357 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-3 [ 357 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4 [ 603 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4 [ 603 ] SUIT Sprint 2017-4, SUIT Sprint 2017-5 [ 603, 604 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-7284 [ 26369 ] DM-8770 [ 28609 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4, SUIT Sprint 2017-5 [ 603, 604 ] SUIT Sprint 2017-4 [ 603 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4 [ 603 ] SUIT Sprint 2017-4, SUIT Sprint 2017-6 [ 603, 609 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4, SUIT Sprint 2017-6 [ 603, 609 ] SUIT Sprint 2017-4 [ 603 ]
            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            We need to collect use cases for this and analyze it to see what needs to be done in Firefly JavaScript API to support it.

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - We need to collect use cases for this and analyze it to see what needs to be done in Firefly JavaScript API to support it.
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8770 [ 28609 ] DM-8771 [ 28610 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Reviewers Nate Lust [ nlust ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8771 [ 28610 ] DM-10570 [ 32500 ]
            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Firefly API currently does not support this. It is moved to https://jira.lsstcorp.org/browse/DM-10570 for future consideration. 

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Firefly API currently does not support this. It is moved to https://jira.lsstcorp.org/browse/DM-10570  for future consideration. 
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            David Shupe and I discussed this just now. There is a useful way that this could be implemented now, without any additional Firefly core work, that would meet the afw.display API and supply equivalent functionality, but based on clicking on buttons associated with "POINT" events rather than on keypresses.

            The afw.display API should be extended to allow supplying an optional "name" argument that is used for the button label. The label should also include the key name that is mandatory in the afw.display API, e.g., the label might be "Variance (v)".

            David Shupe will have to make sure that the x,y coordinates returned are exactly as in DS9, i.e., correctly taking into account issues of offset-0, offset-0.5, and offset-1 pixel coordinate conventions.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - David Shupe and I discussed this just now. There is a useful way that this could be implemented now, without any additional Firefly core work, that would meet the afw.display API and supply equivalent functionality, but based on clicking on buttons associated with "POINT" events rather than on keypresses. The afw.display API should be extended to allow supplying an optional "name" argument that is used for the button label. The label should also include the key name that is mandatory in the afw.display API, e.g., the label might be "Variance (v)". David Shupe will have to make sure that the x,y coordinates returned are exactly as in DS9, i.e., correctly taking into account issues of offset-0, offset-0.5, and offset-1 pixel coordinate conventions.
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            A separate ticket can be filed for the provision of actual keypress detection in Firefly core at a later date.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - A separate ticket can be filed for the provision of actual keypress detection in Firefly core at a later date.
            gpdf Gregory Dubois-Felsmann made changes -
            Component/s display_firefly [ 15115 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4 [ 603 ] SUIT Sprint 2017-4, SUIT Sprint 2019-06 [ 603, 875 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2017-4, SUIT Sprint 2019-06 [ 603, 875 ] SUIT Sprint 2017-4 [ 603 ]
            tjenness Tim Jenness made changes -
            Remote Link This issue links to "Page (Confluence)" [ 35880 ]
            Hide
            tjenness Tim Jenness added a comment -

            Are we still intending to try to do this (and I imagine the assignee should be removed)

            Show
            tjenness Tim Jenness added a comment - Are we still intending to try to do this (and I imagine the assignee should be removed)

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Watchers:
              David Shupe, Gregory Dubois-Felsmann, Tim Jenness, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.