Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8180

Histogram display and expression improvements

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: SUIT
    • Labels:
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      SUIT Sprint 2018-03, SUIT Sprint 2018-04
    • Team:
      Science User Interface

      Description

      Server side now handles the expressions and passes 14 significant digits, which the client can handle.

      This ticket addresses the following issues:

      • Flexible histogram tooltip precision based on the bin width. You should not see bin ranges like "0.000000 to 0.000000" for when the boundaries are small numbers.
      • Histogram and heatmap now handle quoted column names and expressions. (Can be tested with NED.)
      • Histogram options will show range for quoted and unquoted columns.
      • Expressions for all charts are now handled by database. (There will be a separate ticket for cleanup.)

      Original description (Nov.16):

      Histogram display is incorrect for large long values. There are several aspects contributing to this issue:

      1. The data from the server should be passed at the full precision the client can handle.

      To solve this issue, we can either set the format string or avoid formatting table data when passing them in JSON (which would be a separate ticket).

      2. For large long numbers we are loosing precision twice:
      First, when converting log to double on server side:
      new Long(69327485392650247l)).doubleValue()
      result: 6.9327485392650248E16
      Second, in Javascript:
      parseFloat("6.9327485392650248E16")
      result: 69327485392650250

      To solve these issues, the server side code constructing bins should be using the same precision the client side can handle.

        Attachments

          Issue Links

            Activity

            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            DM-11814 will cover this ticket.

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - DM-11814 will cover this ticket.
            Show
            tatianag Tatiana Goldina added a comment - https://github.com/Caltech-IPAC/firefly/pull/590

              People

              Assignee:
              tatianag Tatiana Goldina
              Reporter:
              tatianag Tatiana Goldina
              Watchers:
              Tatiana Goldina, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.