Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8209

Remove check for ANetAstrometryTask in obs_cfht config

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_cfht
    • Labels:
      None
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      DRP S17-1, DRP S17-2
    • Team:
      Data Release Production

      Description

      obs_cfht wraps its config options for astrometry in a try block that falls back to a different set of configurations on failure, assuming that failure is due to the astrometry task having been retargeted to ANetAstrometryTask. Unfortunately, this doesn't actually work, because this block will have already been run by the time the user has an opportunity to retarget the astrometry task. And we've encountered at least one occasion where the catch triggers due to a different exception, which is then masked.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. DM-8832 Butler mapper issue in validate_drp since Jenkins build 663

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Dominique Boutigny, could you please confirm that I'm not removing something you're actually using? I think the way it was before it didn't work (and it was making it hard to see an error Ian was having).

            Show
            jbosch Jim Bosch added a comment - Dominique Boutigny , could you please confirm that I'm not removing something you're actually using? I think the way it was before it didn't work (and it was making it hard to see an error Ian was having).
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I'm bumping this into the S17 cycle as we need to close F16.

            Dominique Boutigny, Jim Bosch: this has been sitting in review for a few weeks now. No tremendous rush, but I just wanted to remind you to make sure it doesn't get forgotten.

            Show
            swinbank John Swinbank added a comment - I'm bumping this into the S17 cycle as we need to close F16. Dominique Boutigny , Jim Bosch : this has been sitting in review for a few weeks now. No tremendous rush, but I just wanted to remind you to make sure it doesn't get forgotten.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Paging Dominique Boutigny, Jim Bosch — can we close this out, please?

            Show
            swinbank John Swinbank added a comment - Paging Dominique Boutigny , Jim Bosch — can we close this out, please?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Nicolas Chotard, I think Dominique Boutigny probably doesn't have time to check that this change doesn't cause in problems in CFHT processing. Could you check it, please?

            Show
            jbosch Jim Bosch added a comment - Nicolas Chotard , I think Dominique Boutigny probably doesn't have time to check that this change doesn't cause in problems in CFHT processing. Could you check it, please?
            Hide
            Permalink
            boutigny Dominique Boutigny added a comment -

            Sorry, I completely missed this one.
            I confirm that this change does not cause any problem in CFHT processing

            Show
            boutigny Dominique Boutigny added a comment - Sorry, I completely missed this one. I confirm that this change does not cause any problem in CFHT processing
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Work was completed on DM-8832, which made other changes to the exact same code. Marking as duplicate and closing as Invalid.

            Show
            jbosch Jim Bosch added a comment - Work was completed on DM-8832 , which made other changes to the exact same code. Marking as duplicate and closing as Invalid.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nicolas Chotard
              Watchers:
              Dominique Boutigny, Jim Bosch, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.