Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-6
    • Team:
      Data Release Production

      Description

      It would be helpful to be able to read a catalog schema without reading the entire catalog (e.g., to prepare for concatenating catalogs). I propose adding static methods:

      Schema::readFits(std::string const& filename);
      Schema::fromFitsMetadata(daf::base::PropertySet & header);
      

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Jim Bosch, this is your baby. Would you like to review this? It's not very large, and has gone through Jenkins.

          price@price-laptop:~/LSST/afw (tickets/DM-8211=) $ git sub
          commit a8cd65a2941e5c484a4d88f71dcabc83b8cbfe33
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Tue Nov 8 12:39:45 2016 -0500
           
              table.Schema: allow construction from FITS file
              
              Sometimes we want the Schema from a catalog without having to read
              the entire catalog (e.g., when setting up for concatenating a bunch
              of catalogs). This patch adds two methods to help with that.
           
           include/lsst/afw/table/Schema.h | 11 +++++++++++
           src/table/Schema.cc             | 14 ++++++++++++++
           tests/testTableIO.py            | 20 ++++++++++++++++++++
           3 files changed, 45 insertions(+)
          

          Show
          price Paul Price added a comment - Jim Bosch , this is your baby. Would you like to review this? It's not very large, and has gone through Jenkins . price@price-laptop:~/LSST/afw (tickets/DM-8211=) $ git sub commit a8cd65a2941e5c484a4d88f71dcabc83b8cbfe33 Author: Paul Price <price@astro.princeton.edu> Date: Tue Nov 8 12:39:45 2016 -0500   table.Schema: allow construction from FITS file Sometimes we want the Schema from a catalog without having to read the entire catalog (e.g., when setting up for concatenating a bunch of catalogs). This patch adds two methods to help with that.   include/lsst/afw/table/Schema.h | 11 +++++++++++ src/table/Schema.cc | 14 ++++++++++++++ tests/testTableIO.py | 20 ++++++++++++++++++++ 3 files changed, 45 insertions(+)
          Hide
          jbosch Jim Bosch added a comment -

          Review complete. Only minor comments on the PR.

          Show
          jbosch Jim Bosch added a comment - Review complete. Only minor comments on the PR.
          Hide
          price Paul Price added a comment -

          Made all changes requested on PR. Jenkins underway on py2 and py3. Once those pass I'll merge.

          Show
          price Paul Price added a comment - Made all changes requested on PR. Jenkins underway on py2 and py3 . Once those pass I'll merge.
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile