Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Templates:

      Description

      lsst.afw.image.readMetadata returns a PropertySet, which doesn't track the order of header keywords. PropertyList is the proper type for FITS headers, so readMetadata should return that instead.

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Russell Owen, would you mind having a look at this, please?

          price@price-laptop:~/LSST/afw (tickets/DM-8213=) $ git sub
          commit 6479d758baad1950ec292cb0afd7ceae2c517059
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Nov 10 11:08:52 2016 -0500
           
              add afw::fits::readMetadata
              
              This version returns a PropertyList instead of a PropertySet.
              Deprecated afw::image::readMetadata (it's in the wrong namespace) and
              converted it to use afw::fits::readMetadata.
           
           include/lsst/afw/fits.h        | 14 ++++++++++++++
           include/lsst/afw/image/Utils.h |  8 ++++++--
           python/lsst/afw/fits/fitsLib.i |  2 ++
           src/fits.cc                    | 41 +++++++++++++++++++++++++++++++++++++++++
           src/image/Utils.cc             | 35 -----------------------------------
           5 files changed, 63 insertions(+), 37 deletions(-)
           
          commit 2d646e04d3535f792db601754a6fde7d33f2d6ac
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Nov 10 11:09:51 2016 -0500
           
              change use of deprecated afw::image::readMetadata
           
           src/formatters/TanWcsFormatter.cc | 3 ++-
           src/formatters/WcsFormatter.cc    | 3 ++-
           2 files changed, 4 insertions(+), 2 deletions(-)
           
          commit 06382ece6f94d8f8b937853cea74558c90a7eeae
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Nov 10 11:10:17 2016 -0500
           
              Remove unused header.
           
           include/lsst/afw/image/Defect.h         | 1 -
           include/lsst/afw/image/Image.h          | 1 -
           include/lsst/afw/image/ImageAlgorithm.h | 1 -
           3 files changed, 3 deletions(-)
          

          Show
          price Paul Price added a comment - Russell Owen , would you mind having a look at this, please? price@price-laptop:~/LSST/afw (tickets/DM-8213=) $ git sub commit 6479d758baad1950ec292cb0afd7ceae2c517059 Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:08:52 2016 -0500   add afw::fits::readMetadata This version returns a PropertyList instead of a PropertySet. Deprecated afw::image::readMetadata (it's in the wrong namespace) and converted it to use afw::fits::readMetadata.   include/lsst/afw/fits.h | 14 ++++++++++++++ include/lsst/afw/image/Utils.h | 8 ++++++-- python/lsst/afw/fits/fitsLib.i | 2 ++ src/fits.cc | 41 +++++++++++++++++++++++++++++++++++++++++ src/image/Utils.cc | 35 ----------------------------------- 5 files changed, 63 insertions(+), 37 deletions(-)   commit 2d646e04d3535f792db601754a6fde7d33f2d6ac Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:09:51 2016 -0500   change use of deprecated afw::image::readMetadata   src/formatters/TanWcsFormatter.cc | 3 ++- src/formatters/WcsFormatter.cc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)   commit 06382ece6f94d8f8b937853cea74558c90a7eeae Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:10:17 2016 -0500   Remove unused header.   include/lsst/afw/image/Defect.h | 1 - include/lsst/afw/image/Image.h | 1 - include/lsst/afw/image/ImageAlgorithm.h | 1 - 3 files changed, 3 deletions(-)
          Hide
          rowen Russell Owen added a comment -

          This looks great.

          I have a few very minor requests on github (including optional modernization of two lines of code).

          Show
          rowen Russell Owen added a comment - This looks great. I have a few very minor requests on github (including optional modernization of two lines of code).
          Hide
          price Paul Price added a comment -

          Thanks Russell.

          Changed to use auto in the place suggested. Didn't change the docs as I believe they should be fine. Will merge soon.

          Show
          price Paul Price added a comment - Thanks Russell. Changed to use auto in the place suggested. Didn't change the docs as I believe they should be fine. Will merge soon.
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Russell Owen
              Watchers:
              Paul Price, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development