Paul Price added a comment - 10/Nov/16 9:13 AM Russell Owen , would you mind having a look at this, please? price@price-laptop:~/LSST/afw (tickets/DM-8213=) $ git sub commit 6479d758baad1950ec292cb0afd7ceae2c517059 Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:08:52 2016 -0500   add afw::fits::readMetadata This version returns a PropertyList instead of a PropertySet. Deprecated afw::image::readMetadata (it's in the wrong namespace) and converted it to use afw::fits::readMetadata.   include/lsst/afw/fits.h | 14 ++++++++++++++ include/lsst/afw/image/Utils.h | 8 ++++++-- python/lsst/afw/fits/fitsLib.i | 2 ++ src/fits.cc | 41 +++++++++++++++++++++++++++++++++++++++++ src/image/Utils.cc | 35 ----------------------------------- 5 files changed, 63 insertions(+), 37 deletions(-)   commit 2d646e04d3535f792db601754a6fde7d33f2d6ac Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:09:51 2016 -0500   change use of deprecated afw::image::readMetadata   src/formatters/TanWcsFormatter.cc | 3 ++- src/formatters/WcsFormatter.cc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)   commit 06382ece6f94d8f8b937853cea74558c90a7eeae Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 10 11:10:17 2016 -0500   Remove unused header.   include/lsst/afw/image/Defect.h | 1 - include/lsst/afw/image/Image.h | 1 - include/lsst/afw/image/ImageAlgorithm.h | 1 - 3 files changed, 3 deletions(-)

Russell Owen added a comment - 14/Nov/16 9:46 AM This looks great. I have a few very minor requests on github (including optional modernization of two lines of code).

Paul Price added a comment - 14/Nov/16 10:47 AM Thanks Russell. Changed to use auto in the place suggested. Didn't change the docs as I believe they should be fine. Will merge soon.

Paul Price added a comment - 14/Nov/16 10:59 AM Merged to master.