Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-822

AstrometryTask must check that all columns present in the schema are in the table

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom, pipe_tasks
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      When you create an AstrometryTask (currently in pipe_tasks but should move to meas_astrom) it adds columns to the schema, which it then blithely uses in its run method even if they are not actually present in the input tables.

      Please add a check that the columns are really there.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          Where is this code checked in? I pulled meas_astrom and found 3 new ticket branches (tickets/DM-818, DM-823 and DM-824), but no sign of DM-822.

          Show
          rowen Russell Owen added a comment - Where is this code checked in? I pulled meas_astrom and found 3 new ticket branches (tickets/ DM-818 , DM-823 and DM-824 ), but no sign of DM-822 .
          Hide
          rowen Russell Owen added a comment -

          The changes on pipe_tasks look fine. If there are also changes in meas_astrom (as per the "Componen/s" field) I could not find it.

          Show
          rowen Russell Owen added a comment - The changes on pipe_tasks look fine. If there are also changes in meas_astrom (as per the "Componen/s" field) I could not find it.
          Hide
          rhl Robert Lupton added a comment -

          Sorry, the meas_astrom component is confusing. This is a task that should be in meas_astrom but is currently in pipe_tasks...

          Show
          rhl Robert Lupton added a comment - Sorry, the meas_astrom component is confusing. This is a task that should be in meas_astrom but is currently in pipe_tasks...

            People

            • Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Russell Owen
              Watchers:
              Robert Lupton, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel