Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8220

Regenerate decam linearizer files with python3

    XMLWordPrintable

    Details

      Description

      The decam linearizer files we have commited to obs_decam are pickles files produced with python2, and required a fix to daf_persistence to specify an encoding:

      if sys.version_info.major >= 3:
          finalItem = pickle.load(infile, encoding="latin1")
      else:
          finalItem = pickle.load(infile)
      

      I believe that we can fix this by just re-running makeLinearizer.py on python 3, to get the encoding explicitly specified, but I'm not certain.

      Once done, we should probably remove that encoding specification from daf_persistence. It would also be a chance to fix the file naming in DM-8219.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            It's not clear whether there are other Py2 pickle files out there.  (The obs_decam ones appear to now be rebuilt upon installation, rather than being committed.)  The extra code in daf_persistence/posixStorage.py doesn't seem to be hurting anything and will relatively soon be obsoleted anyway.

            Show
            ktl Kian-Tat Lim added a comment - It's not clear whether there are other Py2 pickle files out there.  (The obs_decam ones appear to now be rebuilt upon installation, rather than being committed.)  The extra code in daf_persistence/posixStorage.py doesn't seem to be hurting anything and will relatively soon be obsoleted anyway.

              People

              Assignee:
              ktl Kian-Tat Lim
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Hsin-Fang Chiang, John Parejko, Kian-Tat Lim, Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: