Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8232

Make ref config name configurable

    XMLWordPrintable

    Details

    • Story Points:
      10
    • Epic Link:
    • Sprint:
      Alert Production F16 - 11c, Alert Production S17 - 12, Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      Let the config name be set by the indexed reference ingester so that multiple ingested reference datasets can reside in the same repository.

        Attachments

          Issue Links

          contains

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8233 let PhotometryTask take a refObjectLoader

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-257 Support multiple reference catalogs

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8964 Update singleFrameDriver following changes to reference catalogs

          • Done
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-262 Add ref_cats_htm to /datasets

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Turned out I needed to do all the work on this ticket as the changes were not separable between this and DM-8233.

            Show
            krughoff Simon Krughoff added a comment - Turned out I needed to do all the work on this ticket as the changes were not separable between this and DM-8233 .
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            This passed Jenkins this afternoon. I'm giving it to you Colin Slater because you know about this stuff, but I can pass it on to someone else if you can't do it.

            Show
            krughoff Simon Krughoff added a comment - This passed Jenkins this afternoon. I'm giving it to you Colin Slater because you know about this stuff, but I can pass it on to someone else if you can't do it.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Colin Slater I just realized that I hadn't created the PRs for this ticket. They are there now.

            Show
            krughoff Simon Krughoff added a comment - Colin Slater I just realized that I hadn't created the PRs for this ticket. They are there now.
            Hide
            Permalink
            ctslater Colin Slater added a comment -

            Looks good. I think this improves the structure of astrometric and photometric calibration quite a bit. I left some comments in pipe_tasks; looks like there's a bit of a logic bug there but it should be easy to fix. My only broad issue is that "Calib" is pretty overloaded in the task ecosystem at this point, so adding CalibBaseTask makes me a little worried (because of the name, structurally it's the right thing to do). I don't have any great alternatives though (PhotoAstroCalBase is kind of unpleasant), so it's fine with me if you leave it as-is.

            Show
            ctslater Colin Slater added a comment - Looks good. I think this improves the structure of astrometric and photometric calibration quite a bit. I left some comments in pipe_tasks; looks like there's a bit of a logic bug there but it should be easy to fix. My only broad issue is that "Calib" is pretty overloaded in the task ecosystem at this point, so adding CalibBaseTask makes me a little worried (because of the name, structurally it's the right thing to do). I don't have any great alternatives though ( PhotoAstroCalBase is kind of unpleasant), so it's fine with me if you leave it as-is.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            O.K. I've responded on the PR. I ended up going from CalibBaseTask to RefMatchTask since that's basically all it does. It feels like it should really be a mixin, but that's not how we build up tasks at the moment.

            I also took care of your other comments, but let me know if it's not sufficient.

            Show
            krughoff Simon Krughoff added a comment - O.K. I've responded on the PR. I ended up going from CalibBaseTask to RefMatchTask since that's basically all it does. It feels like it should really be a mixin, but that's not how we build up tasks at the moment. I also took care of your other comments, but let me know if it's not sufficient.
            Hide
            Permalink
            ctslater Colin Slater added a comment -

            All the fixes look great, merge away.

            Show
            ctslater Colin Slater added a comment - All the fixes look great, merge away.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Merged.

            Show
            krughoff Simon Krughoff added a comment - Merged.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Colin Slater
              Watchers:
              Colin Slater, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.