Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8273

Missing newlines in ConfigurableField persistence

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_config
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Team:
      Data Release Production

      Description

      ConfigurableField.save uses the Python buffer write method but doesn't append a newline (it should probably append two for readability).

      This is leads to a failure to read persisted configs, first noticed in an lsst_py3 Jenkins run of tickets/DM-8230, in meas_modelfit:testMeasureImage.py:103, in copy.deepcopy.

      My only guess as to how we haven't noticed this before is that it's somehow not causing a problem in Python 2, and we hadn't tested Python 3 until now.

        Activity

        Hide
        jbosch Jim Bosch added a comment -

        Tim Jenness, could you take a quick look, since you've already been following along?

        I've verified that this gets my DM-8230 lsst_py3 Jenkins run to succeed, but I've done no further testing.

        Show
        jbosch Jim Bosch added a comment - Tim Jenness , could you take a quick look, since you've already been following along? I've verified that this gets my DM-8230 lsst_py3 Jenkins run to succeed, but I've done no further testing.
        Hide
        tjenness Tim Jenness added a comment -

        Looks good.

        Show
        tjenness Tim Jenness added a comment - Looks good.

          People

          • Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Tim Jenness
            Watchers:
            Jim Bosch, Tim Jenness
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development