Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8358

Port meas_mosaic to log package

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_mosaic
    • Labels:
      None

      Description

      Switch from using pex_logging to log in meas_mosaic.

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            Yes, I agree that this import would be bad.

            That's strange. This line was not in the version Lauren reviewed. Her comment was about from ... import ... vs import ..., and my question was about that.

            Show
            pgee Perry Gee added a comment - Yes, I agree that this import would be bad. That's strange. This line was not in the version Lauren reviewed. Her comment was about from ... import ... vs import ..., and my question was about that.
            Hide
            swinbank John Swinbank added a comment - - edited

            I think her fundamental point was simply that your imports are wrong, because you are still importing pex_logging rather that lsst.log. She then suggested one particular change, which was based on established practice elsewhere, but isn't (as far as I know) a requirement.

            Show
            swinbank John Swinbank added a comment - - edited I think her fundamental point was simply that your imports are wrong, because you are still importing pex_logging rather that lsst.log. She then suggested one particular change, which was based on established practice elsewhere, but isn't (as far as I know) a requirement.
            Hide
            lauren Lauren MacArthur added a comment -

            Indeed...my main point was that the pex_logging import needed changing. I just pointed to what seems to be the "norm", not the "enforced" (or necessarily "recommended"!) style as far as the logging updates have gone in other packages.

            Show
            lauren Lauren MacArthur added a comment - Indeed...my main point was that the pex_logging import needed changing. I just pointed to what seems to be the "norm", not the "enforced" (or necessarily "recommended"!) style as far as the logging updates have gone in other packages.
            Hide
            pgee Perry Gee added a comment -

            I made the change Lauren ask for, though I used import lsst.log in the other tickets in this sequence.

            Show
            pgee Perry Gee added a comment - I made the change Lauren ask for, though I used import lsst.log in the other tickets in this sequence.
            Hide
            pgee Perry Gee added a comment -

            John Swinbank I think that what was in the pull request was inconsistent with what was in the ticket branch. I have a theory that I am using git incorrectly, and I will send you email to get your opinion. I think this is what is causing me to get so much trouble just before I merge to master, so that I sometimes have to end up recreating the commits on a second branch.

            Show
            pgee Perry Gee added a comment - John Swinbank I think that what was in the pull request was inconsistent with what was in the ticket branch. I have a theory that I am using git incorrectly, and I will send you email to get your opinion. I think this is what is causing me to get so much trouble just before I merge to master, so that I sometimes have to end up recreating the commits on a second branch.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                hchiang2 Hsin-Fang Chiang
                Reviewers:
                John Swinbank
                Watchers:
                Hsin-Fang Chiang, John Swinbank, Lauren MacArthur, Merlin Fisher-Levine, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel