Yes, I agree that this import would be bad.

That's strange. This line was not in the version Lauren reviewed. Her comment was about from ... import ... vs import ..., and my question was about that.

I think her fundamental point was simply that your imports are wrong, because you are still importing pex_logging rather that lsst.log. She then suggested one particular change, which was based on established practice elsewhere, but isn't (as far as I know) a requirement.

Indeed...my main point was that the pex_logging import needed changing. I just pointed to what seems to be the "norm", not the "enforced" (or necessarily "recommended"!) style as far as the logging updates have gone in other packages.

I made the change Lauren ask for, though I used import lsst.log in the other tickets in this sequence.

John Swinbank I think that what was in the pull request was inconsistent with what was in the ticket branch. I have a theory that I am using git incorrectly, and I will send you email to get your opinion. I think this is what is causing me to get so much trouble just before I merge to master, so that I sometimes have to end up recreating the commits on a second branch.