Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8401

Update obs_monocam to work with v12.1 of the stack

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_monocam
    • Labels:
      None

      Description

      • obs_monocam isn't tested, and therefore has been left behind, and no longer works with v12.1 of the stack. This ticket is to update it so that it does. A different ticket should be filed to get it tested so that it is kept up to date...

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          (I believe from Skype discussion that this was meant to go to "in review", so I've done that.)

          Show
          swinbank John Swinbank added a comment - (I believe from Skype discussion that this was meant to go to "in review", so I've done that.)
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Review comments:

          • Please make sure the e-mail address which is associated with the commits (jbrooks@astro0010.rcf.bnl.gov) is also associated with a GitHub account.
          • Don't leave commented out lines in the config files (or elsewhere in the code): if you are replacing something, remove it rather than commenting it.
          Show
          swinbank John Swinbank added a comment - Review comments: The history here is a mess: your tickets/ DM-8401 branch has diverged significantly from master for no very clear reason. I think that what you're asking me to review here is just the contents of 89f3f19f5a016ed321baf25dbe468eac8d6f02b4 and 22a675b498be683152190bc6e81b101517ce6c56 , but maybe there's also stuff on 6a95665d45438d1e54cff6890e2e3ca67bc47934 that you care about. Please clean up and rebase. Please make sure the e-mail address which is associated with the commits (jbrooks@astro0010.rcf.bnl.gov) is also associated with a GitHub account. Don't leave commented out lines in the config files (or elsewhere in the code): if you are replacing something, remove it rather than commenting it. Review the Developer Guide for help with commit messages.

            People

            Assignee:
            mfisherlevine Merlin Fisher-Levine
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            John Swinbank
            Watchers:
            John Swinbank, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.