Wrap obs_test with pybind11

XMLWordPrintable

Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
1
• Sprint:
• Team:

Description

May not require any wrapping, if so then this ticket is just for tracking. Otherwise, adjust SP.

Activity

Hide
Krzysztof Findeisen added a comment - - edited

Has a non-trivial dependency on cameraGeom, and possibly other code. For now I'll assume this can be fixed as part of DM-8423.

Show
Krzysztof Findeisen added a comment - - edited Has a non-trivial dependency on cameraGeom, and possibly other code. For now I'll assume this can be fixed as part of DM-8423 .
Hide
Krzysztof Findeisen added a comment -

This package has some swig-specific code that needed editing, as well as a strange pickling problem. Therefore, it's not as trivial as first assumed.

Show
Krzysztof Findeisen added a comment - This package has some swig-specific code that needed editing, as well as a strange pickling problem. Therefore, it's not as trivial as first assumed.
Hide
Russell Owen added a comment - - edited

I took this over since I had a bit of free time. I hope you don't mind Krzysztof Findeisen.

The existing testComposite.py had a problem: it assumed that you could round trip raw and flat, which is not the case. It is persisted as DecoratedImageU but when the butler gets the data, it adapts the data to LSST standards and turns it into an ExposureU. My solution was two-fold:

• Divide the test into testing get and put.
• For the put test I manually create a raw and flat of the correct data type.

I also changed the use of pickle to write to a string instead of saving to a file, for simplicity.

Note that I changed RotType_x to RotType.x. This is the modern way to do things and I have not wrapped the old way (yet) in afw. If need be I'll add the old constants, but I really hope we can just update the few bits of code that use these constants, instead.

Show
Russell Owen added a comment - - edited I took this over since I had a bit of free time. I hope you don't mind Krzysztof Findeisen . The existing testComposite.py had a problem: it assumed that you could round trip raw and flat , which is not the case. It is persisted as DecoratedImageU but when the butler gets the data, it adapts the data to LSST standards and turns it into an ExposureU . My solution was two-fold: Divide the test into testing get and put . For the put test I manually create a raw and flat of the correct data type. I also changed the use of pickle to write to a string instead of saving to a file, for simplicity. Note that I changed RotType_x to RotType.x . This is the modern way to do things and I have not wrapped the old way (yet) in afw. If need be I'll add the old constants, but I really hope we can just update the few bits of code that use these constants, instead.
Hide
John Parejko added a comment -

Show
Hide
Russell Owen added a comment -

I made your suggested change to create the data ID in setUp.

Show
Russell Owen added a comment - I made your suggested change to create the data ID in setUp .
Hide
Krzysztof Findeisen added a comment -

Russell Owen I made some changes on this branch; did they get wiped when you took over?

Show
Krzysztof Findeisen added a comment - Russell Owen I made some changes on this branch; did they get wiped when you took over?
Hide
Russell Owen added a comment -

I believe I preserved them.

Show
Russell Owen added a comment - I believe I preserved them.

People

• Assignee:
Russell Owen
Reporter:
Pim Schellart [X] (Inactive)
Reviewers:
John Parejko
Watchers:
John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen