# Wrap obs_test with pybind11

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
1
• Epic Link:
• Sprint:
Alert Production S17 - 12
• Team:
Alert Production

#### Description

May not require any wrapping, if so then this ticket is just for tracking. Otherwise, adjust SP.

#### Activity

No builds found.
Pim Schellart [X] (Inactive) created issue -
Pim Schellart [X] (Inactive) made changes -
Field Original Value New Value
Epic Link DM-7717 [ 26925 ]
Pim Schellart [X] (Inactive) made changes -
 Link This issue blocks DM-8419 [ DM-8419 ]
Krzysztof Findeisen made changes -
 Assignee Krzysztof Findeisen [ krzys ]
Krzysztof Findeisen made changes -
 Component/s obs_test [ 10765 ] Team Alert Production [ 10300 ] Labels Pybind11 SciencePipelines
Krzysztof Findeisen made changes -
 Epic Link DM-7717 [ 26925 ] DM-8450 [ 28066 ]
Krzysztof Findeisen made changes -
 Sprint Alert Production S17 - 12 [ 305 ]
Hide
Krzysztof Findeisen added a comment - - edited

Has a non-trivial dependency on cameraGeom, and possibly other code. For now I'll assume this can be fixed as part of DM-8423.

Show
Krzysztof Findeisen added a comment - - edited Has a non-trivial dependency on cameraGeom, and possibly other code. For now I'll assume this can be fixed as part of DM-8423 .
Krzysztof Findeisen made changes -
 Link This issue is blocked by DM-7801 [ DM-7801 ]
Krzysztof Findeisen made changes -
 Link This issue is blocked by DM-8423 [ DM-8423 ]
Krzysztof Findeisen made changes -
 Link This issue is blocked by DM-7801 [ DM-7801 ]
Russell Owen made changes -
 Link This issue blocks DM-8421 [ DM-8421 ]
Krzysztof Findeisen made changes -
 Status To Do [ 10001 ] In Progress [ 3 ]
Krzysztof Findeisen made changes -
 Story Points 0.1 2
Hide
Krzysztof Findeisen added a comment -

This package has some swig-specific code that needed editing, as well as a strange pickling problem. Therefore, it's not as trivial as first assumed.

Show
Krzysztof Findeisen added a comment - This package has some swig-specific code that needed editing, as well as a strange pickling problem. Therefore, it's not as trivial as first assumed.
Russell Owen made changes -
 Assignee Krzysztof Findeisen [ krzys ] Russell Owen [ rowen ]
Hide
Russell Owen added a comment - - edited

I took this over since I had a bit of free time. I hope you don't mind Krzysztof Findeisen.

The existing testComposite.py had a problem: it assumed that you could round trip raw and flat, which is not the case. It is persisted as DecoratedImageU but when the butler gets the data, it adapts the data to LSST standards and turns it into an ExposureU. My solution was two-fold:

• Divide the test into testing get and put.
• For the put test I manually create a raw and flat of the correct data type.

I also changed the use of pickle to write to a string instead of saving to a file, for simplicity.

Note that I changed RotType_x to RotType.x. This is the modern way to do things and I have not wrapped the old way (yet) in afw. If need be I'll add the old constants, but I really hope we can just update the few bits of code that use these constants, instead.

Show
Russell Owen added a comment - - edited I took this over since I had a bit of free time. I hope you don't mind Krzysztof Findeisen . The existing testComposite.py had a problem: it assumed that you could round trip raw and flat , which is not the case. It is persisted as DecoratedImageU but when the butler gets the data, it adapts the data to LSST standards and turns it into an ExposureU . My solution was two-fold: Divide the test into testing get and put . For the put test I manually create a raw and flat of the correct data type. I also changed the use of pickle to write to a string instead of saving to a file, for simplicity. Note that I changed RotType_x to RotType.x . This is the modern way to do things and I have not wrapped the old way (yet) in afw. If need be I'll add the old constants, but I really hope we can just update the few bits of code that use these constants, instead.
Russell Owen made changes -
 Reviewers Pim Schellart [ pschella ] Status In Progress [ 3 ] In Review [ 10004 ]
Russell Owen made changes -
 Story Points 2 1
Russell Owen made changes -
 Reviewers Pim Schellart [ pschella ] John Parejko [ parejkoj ]
Hide
John Parejko added a comment -

Reviewed. See comments on github.

Show
John Parejko added a comment - Reviewed. See comments on github.
John Parejko made changes -
 Status In Review [ 10004 ] Reviewed [ 10101 ]
Hide
Russell Owen added a comment -

I made your suggested change to create the data ID in setUp.

Show
Russell Owen added a comment - I made your suggested change to create the data ID in setUp .
Russell Owen made changes -
 Resolution Done [ 10000 ] Status Reviewed [ 10101 ] Done [ 10002 ]
Hide
Krzysztof Findeisen added a comment -

Russell Owen I made some changes on this branch; did they get wiped when you took over?

Show
Krzysztof Findeisen added a comment - Russell Owen I made some changes on this branch; did they get wiped when you took over?
Hide
Russell Owen added a comment -

I believe I preserved them.

Show
Russell Owen added a comment - I believe I preserved them.

#### People

Assignee:
Russell Owen
Reporter:
Pim Schellart [X] (Inactive)
Reviewers:
John Parejko
Watchers:
John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
Votes:
0 Vote for this issue
Watchers:
4 Start watching this issue

#### Dates

Created:
Updated:
Resolved:

#### Jenkins

No builds found.