Fix Version/s: None
Sprint:Alert Production S17 - 12
May not require any wrapping, if so then this ticket is just for tracking. Otherwise, adjust SP.
|Field||Original Value||New Value|
|Assignee||Krzysztof Findeisen [ krzys ]|
|Component/s||obs_test [ 10765 ]|
|Team||Alert Production [ 10300 ]|
|Sprint||Alert Production S17 - 12 [ 305 ]|
|Status||To Do [ 10001 ]||In Progress [ 3 ]|
This package has some swig-specific code that needed editing, as well as a strange pickling problem. Therefore, it's not as trivial as first assumed.
|Assignee||Krzysztof Findeisen [ krzys ]||Russell Owen [ rowen ]|
I took this over since I had a bit of free time. I hope you don't mind Krzysztof Findeisen.
The existing testComposite.py had a problem: it assumed that you could round trip raw and flat, which is not the case. It is persisted as DecoratedImageU but when the butler gets the data, it adapts the data to LSST standards and turns it into an ExposureU. My solution was two-fold:
- Divide the test into testing get and put.
- For the put test I manually create a raw and flat of the correct data type.
I also changed the use of pickle to write to a string instead of saving to a file, for simplicity.
Note that I changed RotType_x to RotType.x. This is the modern way to do things and I have not wrapped the old way (yet) in afw. If need be I'll add the old constants, but I really hope we can just update the few bits of code that use these constants, instead.
|Reviewers||Pim Schellart [ pschella ]|
|Status||In Progress [ 3 ]||In Review [ 10004 ]|
|Reviewers||Pim Schellart [ pschella ]||John Parejko [ parejkoj ]|
|Status||In Review [ 10004 ]||Reviewed [ 10101 ]|
I made your suggested change to create the data ID in setUp.
|Resolution||Done [ 10000 ]|
|Status||Reviewed [ 10101 ]||Done [ 10002 ]|
Russell Owen I made some changes on this branch; did they get wiped when you took over?
Has a non-trivial dependency on `cameraGeom`, and possibly other code. For now I'll assume this can be fixed as part of