Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8451

Wrap coadd_chisquared with pybind11

    Details

      Attachments

        Issue Links

          Activity

          pschella Pim Schellart [X] (Inactive) created issue -
          pschella Pim Schellart [X] (Inactive) made changes -
          Field Original Value New Value
          Epic Link DM-7717 [ 26925 ]
          swinbank John Swinbank made changes -
          Labels SciencePipelines
          krzys Krzysztof Findeisen made changes -
          Link This issue blocks DM-8461 [ DM-8461 ]
          pschella Pim Schellart [X] (Inactive) made changes -
          Assignee Russell Owen [ rowen ]
          rowen Russell Owen made changes -
          Sprint Alert Production S17 - 1 [ 355 ]
          Team Alert Production [ 10300 ]
          rowen Russell Owen made changes -
          Story Points 0.1 2
          rowen Russell Owen made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          rowen Russell Owen made changes -
          Story Points 2 0.5
          Hide
          rowen Russell Owen added a comment -

          A trivial wrapper

          Show
          rowen Russell Owen added a comment - A trivial wrapper
          rowen Russell Owen made changes -
          Reviewers Krzysztof Findeisen [ krzys ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          krzys Krzysztof Findeisen made changes -
          Epic Link DM-7717 [ 26925 ] DM-8450 [ 28066 ]
          Hide
          krzys Krzysztof Findeisen added a comment -

          Looks good. I'm puzzled by the use of double rather than single quotes in the scons script, but that's it.

          Show
          krzys Krzysztof Findeisen added a comment - Looks good. I'm puzzled by the use of double rather than single quotes in the scons script, but that's it.
          krzys Krzysztof Findeisen made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          rowen Russell Owen added a comment -

          Thank you for the review. I stick to double quotes in the SConscript file, but if folks really care we can change it.

          I started a Jenkins build but it seems to have vanished (it doesn't show up on my page of Jenkins builds). I'll merge for now and hope for the best. It works on OS X.

          Show
          rowen Russell Owen added a comment - Thank you for the review. I stick to double quotes in the SConscript file, but if folks really care we can change it. I started a Jenkins build but it seems to have vanished (it doesn't show up on my page of Jenkins builds). I'll merge for now and hope for the best. It works on OS X.
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Component/s coadd_chisquared [ 13625 ]

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel