Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8456

Wrap meas_extensions_photometryKron with pybind11

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production S17 - 1
    • Team:
      Alert Production

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8419 Wrap meas_base with pybind11

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8453 Wrap meas_algorithms with pybind11

        • Done

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          krzys Krzysztof Findeisen added a comment -

          Looks good. I have questions about a few points, but that's it.

          Show
          krzys Krzysztof Findeisen added a comment - Looks good. I have questions about a few points, but that's it.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          I ended up wrapping KronAperture::getAxes using reference_internal instead of copy. I also clarified commit message for the commit that fixed the clang warning.

          Show
          rowen Russell Owen added a comment - I ended up wrapping KronAperture::getAxes using reference_internal instead of copy . I also clarified commit message for the commit that fixed the clang warning.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Krzysztof Findeisen
            Watchers:
            Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.