Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8456

Wrap meas_extensions_photometryKron with pybind11

    Details

    • Story Points:
      2
    • Sprint:
      Alert Production S17 - 1
    • Team:
      Alert Production

      Attachments

        Issue Links

          Activity

          pschella Pim Schellart [X] (Inactive) created issue -
          pschella Pim Schellart [X] (Inactive) made changes -
          Field Original Value New Value
          Epic Link DM-7717 [ 26925 ]
          swinbank John Swinbank made changes -
          Labels SciencePipelines
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8419 [ DM-8419 ]
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8453 [ DM-8453 ]
          pschella Pim Schellart [X] (Inactive) made changes -
          Assignee Russell Owen [ rowen ]
          rowen Russell Owen made changes -
          Story Points 0.4 2
          rowen Russell Owen made changes -
          Sprint Alert Production S17 - 1 [ 355 ]
          Team Alert Production [ 10300 ]
          rowen Russell Owen made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          rowen Russell Owen made changes -
          Reviewers Krzysztof Findeisen [ krzys ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          krzys Krzysztof Findeisen added a comment -

          Looks good. I have questions about a few points, but that's it.

          Show
          krzys Krzysztof Findeisen added a comment - Looks good. I have questions about a few points, but that's it.
          krzys Krzysztof Findeisen made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          rowen Russell Owen added a comment -

          I ended up wrapping KronAperture::getAxes using reference_internal instead of copy. I also clarified commit message for the commit that fixed the clang warning.

          Show
          rowen Russell Owen added a comment - I ended up wrapping KronAperture::getAxes using reference_internal instead of copy . I also clarified commit message for the commit that fixed the clang warning.
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Component/s meas_extensions_photometryKron [ 12318 ]

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel