Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8457

Wrap meas_deblender with pybind11

    XMLWordPrintable

    Details

      Attachments

        Issue Links

          Activity

          pschella Pim Schellart [X] (Inactive) created issue -
          pschella Pim Schellart [X] (Inactive) made changes -
          Field Original Value New Value
          Epic Link DM-7717 [ 26925 ]
          swinbank John Swinbank made changes -
          Labels SciencePipelines
          krzys Krzysztof Findeisen made changes -
          Link This issue blocks DM-8461 [ DM-8461 ]
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8453 [ DM-8453 ]
          krzys Krzysztof Findeisen made changes -
          Link This issue blocks DM-8460 [ DM-8460 ]
          fred3m Fred Moolekamp made changes -
          Assignee Fred Moolekamp [ fred3m ]
          fred3m Fred Moolekamp made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          fred3m Fred Moolekamp added a comment -

          Pim, do you mind reviewing this ticket for me?

          Show
          fred3m Fred Moolekamp added a comment - Pim, do you mind reviewing this ticket for me?
          fred3m Fred Moolekamp made changes -
          Reviewers Pim Schellart [ pschella ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          fred3m Fred Moolekamp added a comment -

          In case we're keeping track of tests needed upstream: there should be a test for the growFootprint method in afw::detection that makes use of the default argument. Apparently meas_deblender is the first place it was used in the stack.

          Show
          fred3m Fred Moolekamp added a comment - In case we're keeping track of tests needed upstream: there should be a test for the growFootprint method in afw::detection that makes use of the default argument. Apparently meas_deblender is the first place it was used in the stack.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good. Minor comments on PR.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good. Minor comments on PR.
          pschella Pim Schellart [X] (Inactive) made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          fred3m Fred Moolekamp made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          swinbank John Swinbank added a comment -

          Please go ahead and file tickets for tests which you think should be added to afw (or elsewhere in the stack). It's not in scope for this work to write the tests, but we should at least register that they are needed.

          Show
          swinbank John Swinbank added a comment - Please go ahead and file tickets for tests which you think should be added to afw (or elsewhere in the stack). It's not in scope for this work to write the tests, but we should at least register that they are needed.
          tjenness Tim Jenness made changes -
          Component/s meas_deblender [ 10741 ]

            People

            Assignee:
            fred3m Fred Moolekamp
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Pim Schellart [X] (Inactive)
            Watchers:
            Fred Moolekamp, John Swinbank, Pim Schellart [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: