Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8461

Wrap pipe_tasks with pybind11

    XMLWordPrintable

    Details

      Description

      Fix issues in pybind11 wrapping revealed in pipe_tasks.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8462 Wrap pipe_drivers with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8463 Wrap obs_sdss with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8464 Wrap obs_lsstSim with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8465 Wrap meas_modelfit with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8466 Wrap obs_subaru with pybind11

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8419 Wrap meas_base with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8451 Wrap coadd_chisquared with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8453 Wrap meas_algorithms with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8457 Wrap meas_deblender with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8458 Wrap meas_astrom with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8459 Wrap ip_isr with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8460 Wrap ip_diffim with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8877 Wrap skymap with pybind11

          • Done

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Since it's not clear to me that the suffixed names should be part of the public BaseRecord interface, I would prefer to replace the names with get unless Russell has strong objections.

            Show
            krzys Krzysztof Findeisen added a comment - Since it's not clear to me that the suffixed names should be part of the public BaseRecord interface, I would prefer to replace the names with get unless Russell has strong objections.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Due to performance I still lean towards leaving the code along and emulating the old API, but either solution is acceptable to me as long as all code is changed, not just the code that happens to be exposed by the unit tests we have run so far. In other words, I think a global search for each of the missing type-specific "get" method is required. It isn't difficult, just a minor nuisance.

            Show
            rowen Russell Owen added a comment - Due to performance I still lean towards leaving the code along and emulating the old API, but either solution is acceptable to me as long as all code is changed, not just the code that happens to be exposed by the unit tests we have run so far. In other words, I think a global search for each of the missing type-specific "get" method is required. It isn't difficult, just a minor nuisance.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Looks like cleaning this up is best left to DM-8716 after all. getD, at least, is used by some very high level packages like analysis and testingPipeQA. I'll wrap the Swig specializations for now.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Looks like cleaning this up is best left to DM-8716 after all. getD , at least, is used by some very high level packages like analysis and testingPipeQA . I'll wrap the Swig specializations for now.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Russell Owen I've updated afw, meas_base, ip_isr, and pipe_tasks. Can you take another look?

            Show
            krzys Krzysztof Findeisen added a comment - Russell Owen I've updated afw , meas_base , ip_isr , and pipe_tasks . Can you take another look?
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Excellent work. I had one small tweak to a comment (remove or reword) in pipe_tasks, but you can change it or not as you see fit.

            Show
            rowen Russell Owen added a comment - Excellent work. I had one small tweak to a comment (remove or reword) in pipe_tasks, but you can change it or not as you see fit.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.