Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8463

Wrap obs_sdss with pybind11

    Details

    • Story Points:
      0.5
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Attachments

        Issue Links

          Activity

          Hide
          rowen Russell Owen added a comment -

          Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances).

          I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.

          Show
          rowen Russell Owen added a comment - Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances). I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Should be review complete.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Should be review complete.

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: