Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8463

Wrap obs_sdss with pybind11

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8453 Wrap meas_algorithms with pybind11

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8458 Wrap meas_astrom with pybind11

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8461 Wrap pipe_tasks with pybind11

        • Done

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances).

          I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.

          Show
          rowen Russell Owen added a comment - Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances). I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good.
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          Should be review complete.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Should be review complete.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Pim Schellart [X] (Inactive)
            Watchers:
            Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.