Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8463

Wrap obs_sdss with pybind11

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8453 Wrap meas_algorithms with pybind11

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8458 Wrap meas_astrom with pybind11

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8461 Wrap pipe_tasks with pybind11

        • Done

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          pschella Pim Schellart [X] (Inactive) created issue -
          pschella Pim Schellart [X] (Inactive) made changes -
          Field Original Value New Value
          Epic Link DM-7717 [ 26925 ]
          swinbank John Swinbank made changes -
          Labels SciencePipelines
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8453 [ DM-8453 ]
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8458 [ DM-8458 ]
          krzys Krzysztof Findeisen made changes -
          Link This issue is blocked by DM-8461 [ DM-8461 ]
          pschella Pim Schellart [X] (Inactive) made changes -
          Assignee Pim Schellart [ pschella ]
          swinbank John Swinbank made changes -
          Story Points 0.5
          swinbank John Swinbank made changes -
          Sprint DRP S17-3 [ 360 ]
          Team Data Release Production [ 10301 ]
          rowen Russell Owen made changes -
          Assignee Pim Schellart [ pschella ] Russell Owen [ rowen ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances).

          I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.

          Show
          rowen Russell Owen added a comment - Just a few small changes required. For every change I made I looked for the same problem in all the code, in case test coverage isn't good enough (but I found no instances). I did modernize the way that self.interpStyle was computed in scaleSdssZeroPoint.py but otherwise restrained myself from cleaning up the code.
          rowen Russell Owen made changes -
          Reviewers Pim Schellart [ pschella ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          rowen Russell Owen made changes -
          Sprint DRP S17-3 [ 360 ] Alert Production S17 - 2 [ 361 ]
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good.
          pschella Pim Schellart [X] (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In Review [ 10004 ] Done [ 10002 ]
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          Should be review complete.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Should be review complete.
          pschella Pim Schellart [X] (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Done [ 10002 ] Reviewed [ 10101 ]
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          rowen Russell Owen made changes -
          Team Data Release Production [ 10301 ] Alert Production [ 10300 ]
          tjenness Tim Jenness made changes -
          Component/s obs_sdss [ 10763 ]

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Pim Schellart [X] (Inactive)
            Watchers:
            Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.