Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8550

Figure out how to run photometric calibration

    Details

    • Story Points:
      10
    • Sprint:
      Alert Production S17 - 12, Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      Before I can write any tests for jointcal's photometric fitting, I need to at least get it to run. It may be as simple as the following, but it's not clear whether the code will even run, or what else might be necessary.

              fit = jointcalLib.PhotomFit(associations, spm, self.config.posError)
              fit.Minimize("Model")
              chi2 = fit.ComputeChi2()
              print(chi2)
              fit.Minimize("Fluxes")
              chi2 = fit.ComputeChi2()
              print(chi2)
              fit.Minimize("Model Fluxes")
              chi2 = fit.ComputeChi2()
              print(chi2)
      

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Russell Owen: Ok, I think I'm ready for the python portion to be reviewed. It turns out I didn't need to actually add anything to the C++ code, so the review of the refactor you did before stands as is. You can look at the C++ code if you like, but the only things different from before (modulo rebasing) are in python.

            Show
            Parejkoj John Parejko added a comment - Russell Owen : Ok, I think I'm ready for the python portion to be reviewed. It turns out I didn't need to actually add anything to the C++ code, so the review of the refactor you did before stands as is. You can look at the C++ code if you like, but the only things different from before (modulo rebasing) are in python.
            Show
            Parejkoj John Parejko added a comment - FWIW, these are the commits with changes to python code: https://github.com/lsst/jointcal/pull/23/commits/e340747119227a4e7488003eecf98c9405274def https://github.com/lsst/jointcal/pull/23/commits/8c73e680a00e159b49b1609bbabf6d596bad0f18
            Hide
            rowen Russell Owen added a comment -

            Overall the cleanups are much appreciated.

            I put some suggestions and questions on github, including a few that I think should be addressed before merging, including:

            • Please explain how to use JointcalStatistics, and, perhaps, having it compute the statistics at construction.
            • Please log messages instead of printing them in the task.
            Show
            rowen Russell Owen added a comment - Overall the cleanups are much appreciated. I put some suggestions and questions on github, including a few that I think should be addressed before merging, including: Please explain how to use JointcalStatistics, and, perhaps, having it compute the statistics at construction. Please log messages instead of printing them in the task.
            Hide
            Parejkoj John Parejko added a comment -

            I've responded to your points, with one open question about how to architect this whole thing.

            I filed a ticket to redo things with lsst.log some time ago: DM-8547

            Show
            Parejkoj John Parejko added a comment - I've responded to your points, with one open question about how to architect this whole thing. I filed a ticket to redo things with lsst.log some time ago: DM-8547
            Hide
            Parejkoj John Parejko added a comment -

            I responded to all the points in the review, and Russell Owen and I talked about the overall design some. Summary: we'll keep it as-is for now, and wait for a better n-way matcher and/or VisitExposure design to rework it.

            Rebase-flattened the post-review comments, and merged. Now on to reworking the tests to check photometry!

            Show
            Parejkoj John Parejko added a comment - I responded to all the points in the review, and Russell Owen and I talked about the overall design some. Summary: we'll keep it as-is for now, and wait for a better n-way matcher and/or VisitExposure design to rework it. Rebase-flattened the post-review comments, and merged. Now on to reworking the tests to check photometry!

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Russell Owen
                Watchers:
                John Parejko, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel