Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8551

Write lsstSim test for jointcal photometry

    Details

    • Story Points:
      6
    • Sprint:
      Alert Production S17 - 12, Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      Once I have shown that jointcal photometry can run, I should start testing it with lsstSim's twinkles1 data set. There are "known" values to compare to here, so this test can be more stringent than those using external catalogs.

      As part of this, it would be good to make some plots showing the RMS/star across all visits, and compare those to the "known" values/star. That will also help us define the test metric.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Now that the photometric step is running, and I have a basic metric, write some tests!

            Show
            Parejkoj John Parejko added a comment - Now that the photometric step is running, and I have a basic metric, write some tests!
            Hide
            Parejkoj John Parejko added a comment -

            Small review, please (4 files, +84 -70). Though the ticket was to add a jointcal photometry test to lsstSim (which I did), I ended up finding some bugs in some of the calculations. They didn't affect the test code, but they jointcalStatistics gave different results when run from a unittest vs. plot_jointcal_results.py.

            Show
            Parejkoj John Parejko added a comment - Small review, please (4 files, +84 -70). Though the ticket was to add a jointcal photometry test to lsstSim (which I did), I ended up finding some bugs in some of the calculations. They didn't affect the test code, but they jointcalStatistics gave different results when run from a unittest vs. plot_jointcal_results.py.
            Hide
            sullivan Ian Sullivan added a comment -

            The code changes look fine. Most of my comments are requests to add documentation or improve clarity.

            Show
            sullivan Ian Sullivan added a comment - The code changes look fine. Most of my comments are requests to add documentation or improve clarity.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the quick review! I added quite a few docstrings (and discovered the SublimeText plugin "AutoDocstring" which made it really easy) and cleaned up a few other things.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review! I added quite a few docstrings (and discovered the SublimeText plugin "AutoDocstring" which made it really easy) and cleaned up a few other things. Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Ian Sullivan
                Watchers:
                Ian Sullivan, John Parejko, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel