Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: jointcal
-
Labels:
-
Story Points:6
-
Epic Link:
-
Sprint:Alert Production S17 - 1, Alert Production S17 - 2
-
Team:Alert Production
Description
In order to run jointcal photometry on data other than twinkles1, it will probably be necessary to separate the photometric and astrometric reference catalogs. This can probably be managed via configuration parameters (doAstrometry/doPhotometry and astrometrySourceSelector/photometrySourceSelector at least). This would be an opportunity to refactor the guts of jointcal.run() as well.
I only did a quick pass through the C++ part to look for obvious warts (didn't find any, just some minor comments here and there). It looks a bit messy with the formatting and variable naming and I haven't done a more in depth review. Let me know if you think one is needed at this stage.