Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8553

Write jointcal photometry test for cfht

    Details

      Description

      Once I have the tests in place for twinkles, write a similar jointcal photometry test for cfht. This would be the time to replace the currently-broken validation_data_jointcal/cfht data with one updated to have VisitInfo.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            One part of this is going to be done soon: getting the cfht data in testdata_jointcal updated with visitInfo, so those tests stop failing.

            Show
            Parejkoj John Parejko added a comment - One part of this is going to be done soon: getting the cfht data in testdata_jointcal updated with visitInfo, so those tests stop failing.
            Hide
            Parejkoj John Parejko added a comment -

            The PR doesn't fix this ticket, just resolves the problem that the current cfht data in testdata_jointcal no longer works with jointcal. The only human-readable thing to check is the README, I think.

            Show
            Parejkoj John Parejko added a comment - The PR doesn't fix this ticket, just resolves the problem that the current cfht data in testdata_jointcal no longer works with jointcal. The only human-readable thing to check is the README, I think.
            Hide
            mtpatter Maria Patterson [X] (Inactive) added a comment -

            Hey John Parejko, there are 2,808 lines changed in cfht/config/processCcd.py. Did you mean to include that for this PR? If so, it's not a quick review...

            Show
            mtpatter Maria Patterson [X] (Inactive) added a comment - Hey John Parejko , there are 2,808 lines changed in cfht/config/processCcd.py. Did you mean to include that for this PR? If so, it's not a quick review...
            Hide
            Parejkoj John Parejko added a comment -

            That's just a file copied from the data repo: it's auto-generated, so nothing to review. I think the only thing to look at is the readme: everything else is just files copied from the processed repo..

            Show
            Parejkoj John Parejko added a comment - That's just a file copied from the data repo: it's auto-generated, so nothing to review. I think the only thing to look at is the readme: everything else is just files copied from the processed repo..
            Hide
            mtpatter Maria Patterson [X] (Inactive) added a comment -

            Ok, that processCcd.py has a lot of changes (but not the whole file). If it's just the README, that looks fine. My only comment then is that your git commit messages should be imperative tense and not past tense via https://developer.lsst.io/processes/workflow.html#writing-commit-summary-lines.

            Show
            mtpatter Maria Patterson [X] (Inactive) added a comment - Ok, that processCcd.py has a lot of changes (but not the whole file). If it's just the README, that looks fine. My only comment then is that your git commit messages should be imperative tense and not past tense via https://developer.lsst.io/processes/workflow.html#writing-commit-summary-lines .
            Hide
            Parejkoj John Parejko added a comment -

            Thanks. I altered the commit messages and I'll try to remember that for the future. Merged.

            Returning this to "In Progress", since this was only a minor part of the work.

            Show
            Parejkoj John Parejko added a comment - Thanks. I altered the commit messages and I'll try to remember that for the future. Merged. Returning this to "In Progress", since this was only a minor part of the work.
            Hide
            Parejkoj John Parejko added a comment -

            Doing the final step of this (2 line fix in jointcal/tests/test_jointcal_cfht.py) as part of DM-8555, so that all the tests will pass.

            Show
            Parejkoj John Parejko added a comment - Doing the final step of this (2 line fix in jointcal/tests/test_jointcal_cfht.py ) as part of DM-8555 , so that all the tests will pass.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Maria Patterson [X] (Inactive)
                Watchers:
                John Parejko, Maria Patterson [X] (Inactive), Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel