Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8555

Write jointcal photometry test for hsc

    Details

      Description

      Write a tests for jointcal photometric processing on hsc data. Use either the latest validation_data_hsc data, or reprocess an older (smaller) version to get VisitInfo and add it to validation_data_jointcal.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Should be a short review. Handful of test changes in jointcal and a new hsc repo in testdata_jointcal.

            The only human-readable changes to testdata_jointcal would be the README and compression script, everything else is git-lfs-managed output of singleFrameDriver.py.

            Show
            Parejkoj John Parejko added a comment - Should be a short review. Handful of test changes in jointcal and a new hsc repo in testdata_jointcal. The only human-readable changes to testdata_jointcal would be the README and compression script, everything else is git-lfs-managed output of singleFrameDriver.py .
            Hide
            Parejkoj John Parejko added a comment -

            Additional note: I rolled DM-8554 and DM-8553 (each only a two-line change to jointcal, but I also gzipped the decam source catalogs in testdata_jointcal) into this one, in the hopes of getting all the tests to pass together.

            Show
            Parejkoj John Parejko added a comment - Additional note: I rolled DM-8554 and DM-8553 (each only a two-line change to jointcal, but I also gzipped the decam source catalogs in testdata_jointcal) into this one, in the hopes of getting all the tests to pass together.
            Hide
            mrawls Meredith Rawls added a comment -

            This seems fine. I left some comments on GitHub: one suggestion for putting each dataset in a bit more context in the testdata_jointcal README and some minor questions/comments about plotting output, a variable name, and error precision in the jointcal tests.

            Show
            mrawls Meredith Rawls added a comment - This seems fine. I left some comments on GitHub: one suggestion for putting each dataset in a bit more context in the testdata_jointcal README and some minor questions/comments about plotting output, a variable name, and error precision in the jointcal tests.
            Hide
            Parejkoj John Parejko added a comment -

            Jenkins passed!

            https://ci.lsst.codes/job/stack-os-matrix/20289/

            Please take a look at the latest jointcal commit in the PR: I had to check for catalog items with negative fluxes, which could cause trouble depending on the order of the datarefs (in this case, jenkins had the datarefs in a different order and so ran into the problem that I didn't locally).

            Show
            Parejkoj John Parejko added a comment - Jenkins passed! https://ci.lsst.codes/job/stack-os-matrix/20289/ Please take a look at the latest jointcal commit in the PR: I had to check for catalog items with negative fluxes, which could cause trouble depending on the order of the datarefs (in this case, jenkins had the datarefs in a different order and so ran into the problem that I didn't locally).
            Hide
            mrawls Meredith Rawls added a comment -

            Interesting problem, and good fix. Feel free to merge!

            Show
            mrawls Meredith Rawls added a comment - Interesting problem, and good fix. Feel free to merge!
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the review; I think the docs are more useful now.

            Merged, and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review; I think the docs are more useful now. Merged, and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Meredith Rawls
                Watchers:
                John Parejko, Meredith Rawls, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel