Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8598

Dispatch TBL_RESULTS_ACTIVE when table is removed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly, SUIT
    • Labels:
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      SUIT Sprint 2017-01
    • Team:
      Science User Interface

      Description

      If i have 2 or more tables and i switch from one to another, the xy plot gets updated correctly.
      Now, if i close one table, the next table gets active but the plot doesn't refresh/update and fails to show the xy plot of the active table.
      Please check and fix.

      --------------------
      TG 12/7/2016

      The bug is fixed in dev by adding TABLE_REMOVE to syncChartViewer saga in ChartsSync.js However, Loi thinks TBL_RESULTS_ACTIVE should be dispatched when a table is removed.

      To test this ticket, delete TABLE_REMOVE from ChartsSync.js:syncChartViewer saga - the charts should be still in sync with the table when a table is removed.

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. DM-8313 LC viewer: the result table doesn't get updated unless its active (focused)

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8627 Prepare IRSAViewer RC with added features

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8670 Revamp LC results area

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tatianag Tatiana Goldina added a comment -

            Loi Ly I am not getting TablesCntlr.TBL_RESULTS_ACTIVE action when a table is deleted.

            Show
            tatianag Tatiana Goldina added a comment - Loi Ly I am not getting TablesCntlr.TBL_RESULTS_ACTIVE action when a table is deleted.
            Hide
            Permalink
            loi Loi Ly added a comment -

            You are right. When an active table is removed, the active table is updated in the reducer without a separate TBL_RESULTS_ACTIVE action dispatched. You have to move that logic to the action creator. Reassign the ticket to me, if you rather have me work on it.

            Show
            loi Loi Ly added a comment - You are right. When an active table is removed, the active table is updated in the reducer without a separate TBL_RESULTS_ACTIVE action dispatched. You have to move that logic to the action creator. Reassign the ticket to me, if you rather have me work on it.
            Hide
            Permalink
            tatianag Tatiana Goldina added a comment -

            Loi knows what to do.

            Show
            tatianag Tatiana Goldina added a comment - Loi knows what to do.
            Hide
            Permalink
            ejoliet Emmanuel Joliet added a comment -

            Loi Ly, Tatiana Goldina, Xiuqin Wu [X]: remember that any bug found should be fixed also in RC branch to be release soon. Thanks.

            Show
            ejoliet Emmanuel Joliet added a comment - Loi Ly , Tatiana Goldina , Xiuqin Wu [X] : remember that any bug found should be fixed also in RC branch to be release soon. Thanks.
            Hide
            Permalink
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Not in the current RC, but the next RC for January/Feb release.

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Not in the current RC, but the next RC for January/Feb release.

              People

              Assignee:
              loi Loi Ly
              Reporter:
              ejoliet Emmanuel Joliet
              Reviewers:
              Tatiana Goldina
              Watchers:
              Emmanuel Joliet, Loi Ly, Tatiana Goldina, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.