Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8612

build_templates.py creates incorrect test list

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-1
    • Team:
      Data Release Production

      Description

      The pybind11 setup script build_templates.py creates a tests/test.txt file whose file names are relative to the tests/ directory. This breaks the recommended command for running tests (py.test `sed -e '/^#/d' tests/test.txt`), which requires the paths be relative to the project root.

      Note that the resolution or non-resolution of this issue affects the correct answer for DM-8611.

        Attachments

          Issue Links

          has to be done before

          Bug - A problem which impairs or prevents the functions of the product. DM-8611 Pybind11 wrapping tutorial has wrong test setup

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Krzysztof, would you mind reviewing this line change?

            Thanks,
            -Fred

            Show
            fred3m Fred Moolekamp added a comment - Krzysztof, would you mind reviewing this line change? Thanks, -Fred
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Oops, I committed this to the wrong ticket. If it's ok I'll just combine this ticket with DM-8611, since the issues are related and require a combined 2 lines of code to be changed.

            Show
            fred3m Fred Moolekamp added a comment - Oops, I committed this to the wrong ticket. If it's ok I'll just combine this ticket with DM-8611 , since the issues are related and require a combined 2 lines of code to be changed.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            I combined this ticket with the changes from DM-8611.

            Show
            fred3m Fred Moolekamp added a comment - I combined this ticket with the changes from DM-8611 .
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Reviewed with no objections.

            Show
            krzys Krzysztof Findeisen added a comment - Reviewed with no objections.

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Fred Moolekamp, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.