Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8619

Enable testWarper.py with pybind11

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      Alert Production S17 - 12
    • Team:
      Alert Production

      Description

      Wrap as much code as needed to make testWarper.py and testWarpExposure.py work and enable that test.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7057 Complete afw port to pybind11

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7801 Wrap afw::cameraGeom with pybind11

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I had to wrap warping code, MaskedImage varieties of SinglePixel, and DecoratedImage

            Show
            rowen Russell Owen added a comment - I had to wrap warping code, MaskedImage varieties of SinglePixel, and DecoratedImage
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            I don't understand why SinglePixel had to be wrapped. It doesn't appear to be in the python API in the current (SWIG) stack and a quick grep didn't reveal SinglePixel used in any *.i or *.py files.

            Show
            fred3m Fred Moolekamp added a comment - I don't understand why SinglePixel had to be wrapped. It doesn't appear to be in the python API in the current (SWIG) stack and a quick grep didn't reveal SinglePixel used in any *.i or *.py files.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This was needed to provide the usual default value for the padValue argument of the warping functions templated on MaskedImage. I don't know how the SWIG handled that argument; it didn't occur to me to check if it was supported. It may prove useful, though I don't think it is currently specified by any python code.

            Show
            rowen Russell Owen added a comment - This was needed to provide the usual default value for the padValue argument of the warping functions templated on MaskedImage . I don't know how the SWIG handled that argument; it didn't occur to me to check if it was supported. It may prove useful, though I don't think it is currently specified by any python code.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Everything looks good, just a few minor corrections.

            Show
            fred3m Fred Moolekamp added a comment - Everything looks good, just a few minor corrections.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.