Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8645

Implement new matcherSourceSelector object for use in matchOptimisticB code. This links to DM-6824.

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production S17 - 12, Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      astrometrySourceSelector can not be used alone in matchOptimisticB as it tests for two different criteria depending on if it's matching objects(needs good centroid, is a parent object, has a minimum S/N, valid flux) or returning those objects to astrometry.py(all the previous plus is not saturated, is not interpolated, and is not edge). The new source selector matcherSourceSelector will make former selection, astrometrySourceSelector will make the second test. This ticket extends the work of DM-6824.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6824 Use meas.algorithms.astrometrySourceSelector in measOptimisticB

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-9120 matcherSourceSelector incorrectly uses nChild and footprints in isMultiple test.

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8987 Test/implement which badFlags are appropriate for matcherSourceSelector

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            cmorrison Chris Morrison [X] (Inactive) created issue -
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Field Original Value New Value
            Link This issue blocks DM-6824 [ DM-6824 ]
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Started work on matcherSourceSelector.py

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Started work on matcherSourceSelector.py
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Sprint Alert Production S17 - 12 [ 305 ]
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Implemented new sourceSelector matcherSourceSelector.py for use in meas.astrom.matchOptimisticB.py. Also added unittests for this matcher.

            Currently the sourceSelector API does not allow for the use cases required in meas.astrom.matchOptimisticB.py. A method that in the base class that just returns a true/false table for an input list of sources instead of a sub-catalog would possibly take care of this.

            The changes implemented can be found at https://github.com/lsst/meas_algorithms/tree/u/morriscb/matcherSourceSelector

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Implemented new sourceSelector matcherSourceSelector.py for use in meas.astrom.matchOptimisticB.py. Also added unittests for this matcher. Currently the sourceSelector API does not allow for the use cases required in meas.astrom.matchOptimisticB.py. A method that in the base class that just returns a true/false table for an input list of sources instead of a sub-catalog would possibly take care of this. The changes implemented can be found at https://github.com/lsst/meas_algorithms/tree/u/morriscb/matcherSourceSelector
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Reviewers John Parejko [ parejkoj ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            See comments in github: you forgot the unittest, and we should clear up the docstrings to clarify the difference between astrometrySS and matcherSS.

            Show
            Parejkoj John Parejko added a comment - See comments in github: you forgot the unittest, and we should clear up the docstrings to clarify the difference between astrometrySS and matcherSS.
            krughoff Simon Krughoff made changes -
            Sprint Alert Production S17 - 12 [ 305 ] Alert Production S17 - 12, Alert Production S17 - 1 [ 305, 355 ]
            krughoff Simon Krughoff made changes -
            Rank Ranked higher
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Link This issue relates to DM-8987 [ DM-8987 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the new ticket for sorting out badFlags. There are a couple remaining things that I responded to on the PR. Please rebase squash/flatten (and rebase to master) before merging.

            Show
            Parejkoj John Parejko added a comment - Thanks for the new ticket for sorting out badFlags. There are a couple remaining things that I responded to on the PR. Please rebase squash/flatten (and rebase to master) before merging.
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Successfully implemented new matcherSourceSelector and pushed to master. Future work in evaluating what selection further selection criteria to use for this sourceSelector will be taken up in https://jira.lsstcorp.org/browse/DM-8987

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Successfully implemented new matcherSourceSelector and pushed to master. Future work in evaluating what selection further selection criteria to use for this sourceSelector will be taken up in https://jira.lsstcorp.org/browse/DM-8987
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Link This issue relates to DM-9120 [ DM-9120 ]
            krughoff Simon Krughoff made changes -
            Epic Link DM-7366 [ 26452 ]

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Reviewers:
              John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.