Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8645

Implement new matcherSourceSelector object for use in matchOptimisticB code. This links to DM-6824.

    XMLWordPrintable

Details

    • 2
    • Alert Production S17 - 12, Alert Production S17 - 1
    • Alert Production

    Description

      astrometrySourceSelector can not be used alone in matchOptimisticB as it tests for two different criteria depending on if it's matching objects(needs good centroid, is a parent object, has a minimum S/N, valid flux) or returning those objects to astrometry.py(all the previous plus is not saturated, is not interpolated, and is not edge). The new source selector matcherSourceSelector will make former selection, astrometrySourceSelector will make the second test. This ticket extends the work of DM-6824.

      Attachments

        Issue Links

          Activity

            Started work on matcherSourceSelector.py

            cmorrison Chris Morrison [X] (Inactive) added a comment - Started work on matcherSourceSelector.py

            Implemented new sourceSelector matcherSourceSelector.py for use in meas.astrom.matchOptimisticB.py. Also added unittests for this matcher.

            Currently the sourceSelector API does not allow for the use cases required in meas.astrom.matchOptimisticB.py. A method that in the base class that just returns a true/false table for an input list of sources instead of a sub-catalog would possibly take care of this.

            The changes implemented can be found at https://github.com/lsst/meas_algorithms/tree/u/morriscb/matcherSourceSelector

            cmorrison Chris Morrison [X] (Inactive) added a comment - Implemented new sourceSelector matcherSourceSelector.py for use in meas.astrom.matchOptimisticB.py. Also added unittests for this matcher. Currently the sourceSelector API does not allow for the use cases required in meas.astrom.matchOptimisticB.py. A method that in the base class that just returns a true/false table for an input list of sources instead of a sub-catalog would possibly take care of this. The changes implemented can be found at https://github.com/lsst/meas_algorithms/tree/u/morriscb/matcherSourceSelector
            Parejkoj John Parejko added a comment -

            See comments in github: you forgot the unittest, and we should clear up the docstrings to clarify the difference between astrometrySS and matcherSS.

            Parejkoj John Parejko added a comment - See comments in github: you forgot the unittest, and we should clear up the docstrings to clarify the difference between astrometrySS and matcherSS.
            Parejkoj John Parejko added a comment -

            Thanks for the new ticket for sorting out badFlags. There are a couple remaining things that I responded to on the PR. Please rebase squash/flatten (and rebase to master) before merging.

            Parejkoj John Parejko added a comment - Thanks for the new ticket for sorting out badFlags. There are a couple remaining things that I responded to on the PR. Please rebase squash/flatten (and rebase to master) before merging.

            Successfully implemented new matcherSourceSelector and pushed to master. Future work in evaluating what selection further selection criteria to use for this sourceSelector will be taken up in https://jira.lsstcorp.org/browse/DM-8987

            cmorrison Chris Morrison [X] (Inactive) added a comment - Successfully implemented new matcherSourceSelector and pushed to master. Future work in evaluating what selection further selection criteria to use for this sourceSelector will be taken up in https://jira.lsstcorp.org/browse/DM-8987

            People

              cmorrison Chris Morrison [X] (Inactive)
              cmorrison Chris Morrison [X] (Inactive)
              John Parejko
              Chris Morrison [X] (Inactive), John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.