Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8656

meas_astrom tests depend on PyQt4 and Qt4 and break with PyQt5 and Qt5

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production S17 - 12
    • Team:
      Alert Production

      Description

      When building meas_astrom with lsstsw using -b option on CentOS7 with gcc 4.8.5 tests break through a dependency on matplotlib.

      *** error building product meas_astrom.
      		 
      *** exit code = 2
      		 
      *** log is in /opt/lsstsw/build/meas_astrom/_build.log
      		 
      *** last few lines:
      		 
      :::::  [2016-12-13T22:08:07.868579Z]   File "/opt/lsstsw/miniconda/lib/python2
      		 
      .7/site-packages/matplotlib/backends/backend_qt5.py", line 31, in <module>
      		 
      :::::  [2016-12-13T22:08:07.868617Z]     from .qt_compat import QtCore, QtGui,
      		 
       QtWidgets, _getSaveFileName, __version__
      		 
      :::::  [2016-12-13T22:08:07.868716Z]   File "/opt/lsstsw/miniconda/lib/python2
      		 
      .7/site-packages/matplotlib/backends/qt_compat.py", line 137, in <module>
      		 
      :::::  [2016-12-13T22:08:07.868749Z]     from PyQt4 import QtCore, QtGui
      		 
      :::::  [2016-12-13T22:08:07.868763Z] ImportError: No module named PyQt4
      		 
      :::::  [2016-12-13T22:08:07.868775Z] The following tests failed:
      		 
      :::::  [2016-12-13T22:08:07.869806Z] /opt/lsstsw/build/meas_astrom/tests/.test
      		 
      s/testFitTanSipWcsHighOrder.py.failed
      		 
      :::::  [2016-12-13T22:08:07.869939Z] 1 tests failed
      		 
      :::::  [2016-12-13T22:08:07.870705Z] scons: *** [checkTestStatus] Error 1
      		 
      :::::  [2016-12-13T22:08:07.875630Z] scons: building terminated because of err
      		 
      ors.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-8689 In one place code calls log.warning instead of log.warn

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-2588 Catch RuntimeError on matplotlib.pyplot import and remove more unprotected/unnecesary pyplot imports

          • Done

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-5790 Provide unified plotting abstraction layer

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'm happy for that fix as well. If someone from your team could do that tweak it would be great.

            Show
            tjenness Tim Jenness added a comment - I'm happy for that fix as well. If someone from your team could do that tweak it would be great.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I standardized tests and library code to only try to import matplotlib when plotting is first attempted. Furthermore the library code logs a warning and continues without plotting if the import fails. The unit tests raise an exception because plotting is never the norm and if a user specifies it then they can put up with an exception if something is wrong.

            I also standardized on import matplotlib.pyplot as plt, including some older code that used pylab instead of pyplot, and removed a few attempts to set the back end because I think that should be up to the user.

            I left the examples unchanged.

            Show
            rowen Russell Owen added a comment - I standardized tests and library code to only try to import matplotlib when plotting is first attempted. Furthermore the library code logs a warning and continues without plotting if the import fails. The unit tests raise an exception because plotting is never the norm and if a user specifies it then they can put up with an exception if something is wrong. I also standardized on import matplotlib.pyplot as plt , including some older code that used pylab instead of pyplot , and removed a few attempts to set the back end because I think that should be up to the user. I left the examples unchanged.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thank you. Looks good to me and a far more comprehensive cleanup than I was expecting. Thanks for clarifying why you removed the backend setting from that test.

            Show
            tjenness Tim Jenness added a comment - Thank you. Looks good to me and a far more comprehensive cleanup than I was expecting. Thanks for clarifying why you removed the backend setting from that test.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you for the helpful review. Merged and pushed.

            Show
            rowen Russell Owen added a comment - Thank you for the helpful review. Merged and pushed.
            Hide
            Permalink
            jmatt J Matt Peterson [X] (Inactive) added a comment - - edited

            I just confirmed this works on Linux. I had a broken lsstsw install and ran it again with rebuild -r tickets/DM-8656 and it built successfully. Thanks.

            EDIT: Updated that it works on Linux specifically.

            Show
            jmatt J Matt Peterson [X] (Inactive) added a comment - - edited I just confirmed this works on Linux. I had a broken lsstsw install and ran it again with rebuild -r tickets/ DM-8656 and it built successfully. Thanks. EDIT: Updated that it works on Linux specifically.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              jmatt J Matt Peterson [X] (Inactive)
              Reviewers:
              Tim Jenness
              Watchers:
              J Matt Peterson [X] (Inactive), John Parejko, Meredith Rawls, Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.