Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8715

Fix or remove pickling support for Match lists with pybind11

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP S17-3
    • Team:
      Data Release Production

      Description

      In Swig `MatchList` objects are (un)pickled by creating a `Catalog` of the contained `Record` type and the (un)pickling that.
      With pybind11 this is not possible because `MatchList` is just a Python `list` of `Match` objects. Pickling them individually (via the same route) does not make much sense.
      It is unclear if this pickling support is actually needed anywhere outside of testSourceMatch.py where it is currently disabled (as of DM-8415).
      This ticket aims to either fix or permanently remove this functionality when the need for it becomes clear.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9100 Merge pybind11 branches to master

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8462 Wrap pipe_drivers with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9156 Wrap ci_hsc with pybind11

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Plan:

            1. Remove them
            2. Run pipe_drivers, ci_hsc, check that nothing breaks.
            Show
            swinbank John Swinbank added a comment - Plan: Remove them Run pipe_drivers, ci_hsc, check that nothing breaks.
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            There was nothing to remove, except the disabled test.
            I assume we are far enough along to safely say it isn't needed?

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - There was nothing to remove, except the disabled test. I assume we are far enough along to safely say it isn't needed?
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Looks fine. We can always bring it back from the dead if we find a use for it.

            Show
            swinbank John Swinbank added a comment - Looks fine. We can always bring it back from the dead if we find a use for it.
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Jim Bosch, John Swinbank
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.