# Fix or remove pickling support for Match lists with pybind11

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
2
• Sprint:
DRP S17-3
• Team:
Data Release Production

## Description

In Swig MatchList objects are (un)pickled by creating a Catalog of the contained Record type and the (un)pickling that.
With pybind11 this is not possible because MatchList is just a Python list of Match objects. Pickling them individually (via the same route) does not make much sense.
It is unclear if this pickling support is actually needed anywhere outside of testSourceMatch.py where it is currently disabled (as of DM-8415).
This ticket aims to either fix or permanently remove this functionality when the need for it becomes clear.

## Activity

Hide
John Swinbank added a comment -

Plan:

1. Remove them
2. Run pipe_drivers, ci_hsc, check that nothing breaks.
Show
John Swinbank added a comment - Plan: Remove them Run pipe_drivers, ci_hsc, check that nothing breaks.
Hide
Pim Schellart [X] (Inactive) added a comment -

There was nothing to remove, except the disabled test.
I assume we are far enough along to safely say it isn't needed?

Show
Pim Schellart [X] (Inactive) added a comment - There was nothing to remove, except the disabled test. I assume we are far enough along to safely say it isn't needed?
Hide
John Swinbank added a comment -

Looks fine. We can always bring it back from the dead if we find a use for it.

Show
John Swinbank added a comment - Looks fine. We can always bring it back from the dead if we find a use for it.
Hide
Pim Schellart [X] (Inactive) added a comment -

Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.

Show
Pim Schellart [X] (Inactive) added a comment - Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.

## People

• Assignee:
Pim Schellart [X] (Inactive)
Reporter:
Pim Schellart [X] (Inactive)
Reviewers:
Jim Bosch, John Swinbank
Watchers:
Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)