Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8715

Fix or remove pickling support for Match lists with pybind11

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      DRP S17-3
    • Team:
      Data Release Production

      Description

      In Swig `MatchList` objects are (un)pickled by creating a `Catalog` of the contained `Record` type and the (un)pickling that.
      With pybind11 this is not possible because `MatchList` is just a Python `list` of `Match` objects. Pickling them individually (via the same route) does not make much sense.
      It is unclear if this pickling support is actually needed anywhere outside of testSourceMatch.py where it is currently disabled (as of DM-8415).
      This ticket aims to either fix or permanently remove this functionality when the need for it becomes clear.

        Attachments

          Issue Links

            Activity

            pschella Pim Schellart [X] (Inactive) created issue -
            pschella Pim Schellart [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-7717 [ 26925 ]
            swinbank John Swinbank made changes -
            Team Data Release Production [ 10301 ]
            jbosch Jim Bosch made changes -
            Link This issue blocks DM-9100 [ DM-9100 ]
            jbosch Jim Bosch made changes -
            Link This issue is blocked by DM-9099 [ DM-9099 ]
            swinbank John Swinbank made changes -
            Story Points 4 2
            Hide
            swinbank John Swinbank added a comment -

            Plan:

            1. Remove them
            2. Run pipe_drivers, ci_hsc, check that nothing breaks.
            Show
            swinbank John Swinbank added a comment - Plan: Remove them Run pipe_drivers, ci_hsc, check that nothing breaks.
            swinbank John Swinbank made changes -
            Link This issue is blocked by DM-9156 [ DM-9156 ]
            swinbank John Swinbank made changes -
            Link This issue is blocked by DM-8462 [ DM-8462 ]
            swinbank John Swinbank made changes -
            Link This issue is blocked by DM-9099 [ DM-9099 ]
            swinbank John Swinbank made changes -
            Assignee Pim Schellart [ pschella ]
            swinbank John Swinbank made changes -
            Sprint DRP S17-3 [ 360 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            There was nothing to remove, except the disabled test.
            I assume we are far enough along to safely say it isn't needed?

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - There was nothing to remove, except the disabled test. I assume we are far enough along to safely say it isn't needed?
            pschella Pim Schellart [X] (Inactive) made changes -
            Reviewers Jim Bosch, John Swinbank [ jbosch, swinbank ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            swinbank John Swinbank added a comment -

            Looks fine. We can always bring it back from the dead if we find a use for it.

            Show
            swinbank John Swinbank added a comment - Looks fine. We can always bring it back from the dead if we find a use for it.
            swinbank John Swinbank made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Since the reviewer list was more of an "and / or" type thing and this is basically trivial I merged it.
            pschella Pim Schellart [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                Jim Bosch, John Swinbank
                Watchers:
                Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel