Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8790

DPDD units for Ixx, Iyy, Ixy are incorrect

    Details

    • Team:
      Architecture

      Description

      These quantities have units of (angular size)^2, but the units listed for them in the DPDD tables (Tables 1, 2, and 4) are nmgy asec^2.

        Attachments

          Activity

          jbosch Jim Bosch created issue -
          jbosch Jim Bosch made changes -
          Field Original Value New Value
          Summary DPDD units fox Ixx, Iyy, Ixy are incorrect DPDD units for Ixx, Iyy, Ixy are incorrect
          tjenness Tim Jenness made changes -
          Assignee Tim Jenness [ tjenness ]
          tjenness Tim Jenness made changes -
          Team Architecture [ 10304 ]
          tjenness Tim Jenness made changes -
          Component/s Requirements Documents [ 12815 ]
          Hide
          tjenness Tim Jenness added a comment -

          If it's just a case of changing the units in the table to be (angular size)^2 then I can do that (although it's not entirely clear how we write that unit in code).

          Show
          tjenness Tim Jenness added a comment - If it's just a case of changing the units in the table to be (angular size)^2 then I can do that (although it's not entirely clear how we write that unit in code).
          Hide
          jbosch Jim Bosch added a comment -

          The algorithms will produce measurements in pixels^2, which will be converted to angular units via the WCS just prior to or just after database loading. It's likely that conversion will involve an intermediate step in radians, since that's our angular unit in the rest of the codebase, but given the rest of the table in the DPDD it looks like the final units will be arcsec^2.

          Show
          jbosch Jim Bosch added a comment - The algorithms will produce measurements in pixels^2, which will be converted to angular units via the WCS just prior to or just after database loading. It's likely that conversion will involve an intermediate step in radians, since that's our angular unit in the rest of the codebase, but given the rest of the table in the DPDD it looks like the final units will be arcsec^2.
          Hide
          tjenness Tim Jenness added a comment -

          I've just pushed a fix for this. Can you please check I got it correct (red text means it will be removed when DPDD is accepted by change control board).

          Show
          tjenness Tim Jenness added a comment - I've just pushed a fix for this. Can you please check I got it correct (red text means it will be removed when DPDD is accepted by change control board).
          tjenness Tim Jenness made changes -
          Reviewers Jim Bosch [ jbosch ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          jbosch Jim Bosch added a comment -

          Looks great, thanks!

          (I only looked at the last commit on this branch; I assume the rest will be reviewed elsewhere).

          Show
          jbosch Jim Bosch added a comment - Looks great, thanks! (I only looked at the last commit on this branch; I assume the rest will be reviewed elsewhere).
          jbosch Jim Bosch made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          tjenness Tim Jenness added a comment -

          Yes, although I think there is only one commit on that branch (the base branch is dmsr-refresh).

          Show
          tjenness Tim Jenness added a comment - Yes, although I think there is only one commit on that branch (the base branch is dmsr-refresh ).
          Hide
          tjenness Tim Jenness added a comment -

          Merged to the development branch (dmsr-refresh).

          Show
          tjenness Tim Jenness added a comment - Merged to the development branch ( dmsr-refresh ).
          tjenness Tim Jenness made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Labels LSE-163

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: