Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8809

Minor cleanup of build_templates.py

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      The script `build_templates.py` associated with dmtn-26 has some minor flake8 issues including an unused import, some variables that are set but never used, and PEP8 violations.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          Ready for inspection

          Show
          rowen Russell Owen added a comment - Ready for inspection
          Hide
          fred3m Fred Moolekamp added a comment -

          Looks good to me. Krzysztof's ticket was focused on removing whitespace, so your linter caught a few things that he missed.

          Show
          fred3m Fred Moolekamp added a comment - Looks good to me. Krzysztof's ticket was focused on removing whitespace, so your linter caught a few things that he missed.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Fred Moolekamp
            Watchers:
            Fred Moolekamp, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.