Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8830

Fix accounting for fraction of successful measurements

    Details

      Description

      The final accounting for success/fail of the KPMs in `validateDrp.py` appears to be off:

      =================================================================
      design level summary
      =================================================================
      FAILED (37/21 measurements)
      =================================================================
      

      1. Investigate why this is happening (likely a counter not being reset, or the denominator not being updated).
      2. Decide on correct accounting and implement.

        Attachments

          Activity

          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          measurementCount is updated on a per-filter basis, but currentFailCount is accumulated across all filters.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - measurementCount is updated on a per-filter basis, but currentFailCount is accumulated across all filters.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          OK, I have a fix in tickets/DM-8830.

          It builds on the tickets/DM-6328 changes to handle the HSC filters, because validation_data_hsc is the one validation_* data set that has multiple filters and so this is what I used to test these changes.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - OK, I have a fix in tickets/ DM-8830 . It builds on the tickets/ DM-6328 changes to handle the HSC filters, because validation_data_hsc is the one validation_* data set that has multiple filters and so this is what I used to test these changes.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Quick review.
          Fixes accounting of successful measurements through better tracking across multiple filters.

          I've run master and get:

          FAILED (37/21 measurements)
          

          I run DM-8830 and get

          FAILED (37/63 measurements)
          

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Quick review. Fixes accounting of successful measurements through better tracking across multiple filters. I've run master and get: FAILED (37/21 measurements) I run DM-8830 and get FAILED (37/63 measurements)
          Hide
          jsick Jonathan Sick added a comment -

          Looks great, thanks.

          Show
          jsick Jonathan Sick added a comment - Looks great, thanks.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Merged to master.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

            People

            • Assignee:
              wmwood-vasey Michael Wood-Vasey
              Reporter:
              wmwood-vasey Michael Wood-Vasey
              Reviewers:
              Jonathan Sick
              Watchers:
              Jonathan Sick, Michael Wood-Vasey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: