Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Validation
-
Labels:
-
Story Points:1
-
Epic Link:
-
Team:SQuaRE
Description
The final accounting for success/fail of the KPMs in `validateDrp.py` appears to be off:
=================================================================
|
design level summary
|
=================================================================
|
FAILED (37/21 measurements)
|
=================================================================
|
1. Investigate why this is happening (likely a counter not being reset, or the denominator not being updated).
2. Decide on correct accounting and implement.
Attachments
Activity
Michael Wood-Vasey
added a comment - OK, I have a fix in tickets/ DM-8830 .
It builds on the tickets/ DM-6328 changes to handle the HSC filters, because validation_data_hsc is the one validation_* data set that has multiple filters and so this is what I used to test these changes. Quick review.
Fixes accounting of successful measurements through better tracking across multiple filters.
I've run master and get:
FAILED (37/21 measurements)
|
I run DM-8830 and get
FAILED (37/63 measurements)
|
Michael Wood-Vasey
added a comment - Quick review.
Fixes accounting of successful measurements through better tracking across multiple filters.
I've run master and get:
FAILED (37/21 measurements)
I run DM-8830 and get
FAILED (37/63 measurements)
Looks great, thanks.
Merged to master.
Michael Wood-Vasey
added a comment - Merged to master. 
measurementCount is updated on a per-filter basis, but currentFailCount is accumulated across all filters.