Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8842

LeastSqFitter1d(..., unsigned int order) should be signed

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Sprint:
      Alert Production S17 - 4
    • Team:
      Alert Production

      Description

      LeastSqFitter1d's constructor's order parameter is unsigned int. However it is stored as int and LeastSqFitter2d uses int in both places.

      I suggest switching to int. The existing code always supplies a small positive integer, so it's safe and trivial to fix. However, it will require the same change to the pybind11 interface file.

      I further suggest not changing this until after the pybind11 transition. Then change it and make sure the whole stack builds.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          Looks great. Thanks for fixing this!

          Show
          rowen Russell Owen added a comment - Looks great. Thanks for fixing this!

            People

            Assignee:
            mrawls Meredith Rawls
            Reporter:
            rowen Russell Owen
            Reviewers:
            Russell Owen
            Watchers:
            Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.