Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru, pipe_drivers
    • Labels:
      None
    • Templates:
    • Story Points:
      4
    • Sprint:
      DRP S17-2
    • Team:
      Data Release Production

      Description

      A year has gone by since our last calibs were taken, and so we need to create more to support data obtained in 2016.

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          So far, this has involved figuring out what raw data to use, pulling raw data from IPMU, ingesting into the repo and debugging failures in the calib construction.

          Show
          price Paul Price added a comment - So far, this has involved figuring out what raw data to use, pulling raw data from IPMU, ingesting into the repo and debugging failures in the calib construction.
          Hide
          price Paul Price added a comment -

          The calibs are in /tigress/HSC/HSC/CALIB-LSST-20160105.

          Nate Lust, would you please review the code changes, in obs_subaru and pipe_drivers?

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-8913=) $ git sub
          commit f1d17af931ce064a5d5c921c591e19c90ff8b8f1
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Jan 9 12:29:55 2017 -0500
           
              add HSC filters NB0468 and NB0926
           
           python/lsst/obs/hsc/hscMapper.py | 4 ++++
           1 file changed, 4 insertions(+)
           
          commit 381c0f12e0212552b6b02d818a92f30f7e4d5d09
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Jan 16 14:19:39 2017 -0500
           
              config: adapt to fringe construction change
              
              'background' was renamed 'subtractBackground'.
           
           config/fringe.py | 2 +-
           1 file changed, 1 insertion(+), 1 deletion(-)
           
           
          price@price-laptop:~/LSST/pipe/drivers (tickets/DM-8913=) $ git sub
          commit e9454d0da7e360409025b0737fb1dc69a50a6563
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Jan 16 12:57:29 2017 -0500
           
              constructCalibs: fix background subtraction on fringe
              
              Change to use SubtractBackgroundTask wasn't complete.
           
           python/lsst/pipe/drivers/constructCalibs.py | 4 +++-
           1 file changed, 3 insertions(+), 1 deletion(-)
           
          commit 03fb1f52061079706b69d4b9bd3e6a5da49dc7c5
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Jan 16 16:03:54 2017 -0500
           
              DarkCombineTask: set exptime and darktime in VisitInfo
              
              We have previously set the exposure time via headers, but now
              we have an object that should contain the values.
           
           python/lsst/pipe/drivers/constructCalibs.py | 3 +--
           1 file changed, 1 insertion(+), 2 deletions(-)
          

          Show
          price Paul Price added a comment - The calibs are in /tigress/HSC/HSC/CALIB-LSST-20160105 . Nate Lust , would you please review the code changes, in obs_subaru and pipe_drivers? price@price-laptop:~/LSST/obs/subaru (tickets/DM-8913=) $ git sub commit f1d17af931ce064a5d5c921c591e19c90ff8b8f1 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jan 9 12:29:55 2017 -0500   add HSC filters NB0468 and NB0926   python/lsst/obs/hsc/hscMapper.py | 4 ++++ 1 file changed, 4 insertions(+)   commit 381c0f12e0212552b6b02d818a92f30f7e4d5d09 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jan 16 14:19:39 2017 -0500   config: adapt to fringe construction change 'background' was renamed 'subtractBackground'.   config/fringe.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)     price@price-laptop:~/LSST/pipe/drivers (tickets/DM-8913=) $ git sub commit e9454d0da7e360409025b0737fb1dc69a50a6563 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jan 16 12:57:29 2017 -0500   constructCalibs: fix background subtraction on fringe Change to use SubtractBackgroundTask wasn't complete.   python/lsst/pipe/drivers/constructCalibs.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)   commit 03fb1f52061079706b69d4b9bd3e6a5da49dc7c5 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jan 16 16:03:54 2017 -0500   DarkCombineTask: set exptime and darktime in VisitInfo We have previously set the exposure time via headers, but now we have an object that should contain the values.   python/lsst/pipe/drivers/constructCalibs.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
          Hide
          price Paul Price added a comment -

          getVisits.py: this is how I figured out which visits were used by Yasuda-san to build his calibs.

          Show
          price Paul Price added a comment - getVisits.py: this is how I figured out which visits were used by Yasuda-san to build his calibs.
          Hide
          nlust Nate Lust added a comment -

          I will not be able to review this in the near term, but if it can wait a bit then I will be happy to.

          Show
          nlust Nate Lust added a comment - I will not be able to review this in the near term, but if it can wait a bit then I will be happy to.
          Hide
          price Paul Price added a comment -

          Sorry for bothering you, Nate.

          Fred Moolekamp, are you able to review these changes?

          Show
          price Paul Price added a comment - Sorry for bothering you, Nate. Fred Moolekamp , are you able to review these changes?
          Hide
          fred3m Fred Moolekamp added a comment -

          I can, but you'll have to get in line. I have another review and an issue I have to complete quickly because it's blocking other tickets. I should be able to get to this tomorrow or the day after, so as long as that time frame is ok then I'm happy to review this.

          Show
          fred3m Fred Moolekamp added a comment - I can, but you'll have to get in line. I have another review and an issue I have to complete quickly because it's blocking other tickets. I should be able to get to this tomorrow or the day after, so as long as that time frame is ok then I'm happy to review this.
          Hide
          fred3m Fred Moolekamp added a comment -

          Paul Price if you just wanted me to review the code and that it is up to par I've done that. But I don't know what the HSC calibs are, when and how they are used, and why new filters would need to be added. So if you need a more thorough review I'll need a little more background than what is contained in the ticket. Also please make sure to comment the ticket when the tests have been passed in Jenkins (although I'm guessing that the py3 stack hasn't made it this far yet...).

          Show
          fred3m Fred Moolekamp added a comment - Paul Price if you just wanted me to review the code and that it is up to par I've done that. But I don't know what the HSC calibs are, when and how they are used, and why new filters would need to be added. So if you need a more thorough review I'll need a little more background than what is contained in the ticket. Also please make sure to comment the ticket when the tests have been passed in Jenkins (although I'm guessing that the py3 stack hasn't made it this far yet...).
          Hide
          price Paul Price added a comment -

          I don't think there's a need to look at the calibs themselves, as I've verified that they work. Reviewing the code changes is more important.

          The calibs are the bias, dark, flat and fringe frames used in ISR for HSC. We needed to build some more because we haven't built any for the last year, and I needed to process some recent data. I needed to add new filters to obs_subaru because some of the new bias frames were observed using those filters, and they weren't being recognised, resulting in errors.

          The code changes have passed Jenkins.

          Show
          price Paul Price added a comment - I don't think there's a need to look at the calibs themselves, as I've verified that they work. Reviewing the code changes is more important. The calibs are the bias, dark, flat and fringe frames used in ISR for HSC. We needed to build some more because we haven't built any for the last year, and I needed to process some recent data. I needed to add new filters to obs_subaru because some of the new bias frames were observed using those filters, and they weren't being recognised, resulting in errors. The code changes have passed Jenkins .
          Hide
          price Paul Price added a comment -

          Thanks, Fred.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks, Fred. Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Nate Lust, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile