Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8913

Create new HSC calibs

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru, pipe_drivers
    • Labels:
      None

      Description

      A year has gone by since our last calibs were taken, and so we need to create more to support data obtained in 2016.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Sorry for bothering you, Nate.

            Fred Moolekamp, are you able to review these changes?

            Show
            price Paul Price added a comment - Sorry for bothering you, Nate. Fred Moolekamp , are you able to review these changes?
            Hide
            fred3m Fred Moolekamp added a comment -

            I can, but you'll have to get in line. I have another review and an issue I have to complete quickly because it's blocking other tickets. I should be able to get to this tomorrow or the day after, so as long as that time frame is ok then I'm happy to review this.

            Show
            fred3m Fred Moolekamp added a comment - I can, but you'll have to get in line. I have another review and an issue I have to complete quickly because it's blocking other tickets. I should be able to get to this tomorrow or the day after, so as long as that time frame is ok then I'm happy to review this.
            Hide
            fred3m Fred Moolekamp added a comment -

            Paul Price if you just wanted me to review the code and that it is up to par I've done that. But I don't know what the HSC calibs are, when and how they are used, and why new filters would need to be added. So if you need a more thorough review I'll need a little more background than what is contained in the ticket. Also please make sure to comment the ticket when the tests have been passed in Jenkins (although I'm guessing that the py3 stack hasn't made it this far yet...).

            Show
            fred3m Fred Moolekamp added a comment - Paul Price if you just wanted me to review the code and that it is up to par I've done that. But I don't know what the HSC calibs are, when and how they are used, and why new filters would need to be added. So if you need a more thorough review I'll need a little more background than what is contained in the ticket. Also please make sure to comment the ticket when the tests have been passed in Jenkins (although I'm guessing that the py3 stack hasn't made it this far yet...).
            Hide
            price Paul Price added a comment -

            I don't think there's a need to look at the calibs themselves, as I've verified that they work. Reviewing the code changes is more important.

            The calibs are the bias, dark, flat and fringe frames used in ISR for HSC. We needed to build some more because we haven't built any for the last year, and I needed to process some recent data. I needed to add new filters to obs_subaru because some of the new bias frames were observed using those filters, and they weren't being recognised, resulting in errors.

            The code changes have passed Jenkins.

            Show
            price Paul Price added a comment - I don't think there's a need to look at the calibs themselves, as I've verified that they work. Reviewing the code changes is more important. The calibs are the bias, dark, flat and fringe frames used in ISR for HSC. We needed to build some more because we haven't built any for the last year, and I needed to process some recent data. I needed to add new filters to obs_subaru because some of the new bias frames were observed using those filters, and they weren't being recognised, resulting in errors. The code changes have passed Jenkins .
            Hide
            price Paul Price added a comment -

            Thanks, Fred.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks, Fred. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Fred Moolekamp
                Watchers:
                Fred Moolekamp, Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: