Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8951

Add TE1 and TE2 KPMs to validate_drp using code developed in DM-3040

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Validation
    • Labels:
      None

      Description

      In Summer 2015, Bob Armstrong wrote code to calculate the residual ellipticity KPM: TE1 and TE2

      https://jira.lsstcorp.org/browse/DM-3040

      Add this code to add TE1 and TE2 to the KPMs calculated in validate_drp

        Attachments

          Issue Links

            Activity

            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            Thanks Tim Jenness for the link to settled practice for envPrepend.

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - Thanks Tim Jenness for the link to settled practice for envPrepend .
            Hide
            Parejkoj John Parejko added a comment -

            See comments in the PR.

            Show
            Parejkoj John Parejko added a comment - See comments in the PR.
            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            John Parejko Could you take another look at this PR? Specifically, take a look at the tests I've added in tests/test_tex.py and double-check that I didn't write anything stupid in tests/test_util.py, which currently just checks the ellipticity calculation.

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - John Parejko Could you take another look at this PR? Specifically, take a look at the tests I've added in tests/test_tex.py and double-check that I didn't write anything stupid in tests/test_util.py , which currently just checks the ellipticity calculation.
            Hide
            Parejkoj John Parejko added a comment -

            I've added some comments on the new code. There are still some open questions from before as well. Thanks for expanding the tests!

            Show
            Parejkoj John Parejko added a comment - I've added some comments on the new code. There are still some open questions from before as well. Thanks for expanding the tests!
            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            Thanks, John Parejko, for all of the review work.

            Merged to master.

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - Thanks, John Parejko , for all of the review work. Merged to master.

              People

              Assignee:
              wmwood-vasey Michael Wood-Vasey [X] (Inactive)
              Reporter:
              wmwood-vasey Michael Wood-Vasey [X] (Inactive)
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Michael Wood-Vasey [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.